Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enhance main README with comprehensive documentation #390

Closed
wants to merge 1 commit into from

Conversation

VolodymyrBg
Copy link
Contributor

  • Add project status badges and key features section
  • Include detailed contributing guidelines
  • Add troubleshooting section with common solutions
  • Improve documentation structure and readability
  • Add additional resources and links
  • Update formatting and visual presentation

- Add project status badges and key features section
- Include detailed contributing guidelines
- Add troubleshooting section with common solutions
- Improve documentation structure and readability
- Add additional resources and links
- Update formatting and visual presentation
@VolodymyrBg VolodymyrBg requested a review from a team as a code owner January 31, 2025 20:27
Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Unfortunately, I think this just adds churn and length to the doc. Leaving it open for now with some comments but as is, NACK

Hemi is an EVM-compatible L2 blockchain that combines the security of Bitcoin with the programmability of Ethereum.
Hemi is an EVM-compatible L2 blockchain that combines the security of Bitcoin with the programmability of Ethereum. It provides a robust, scalable solution for decentralized applications while leveraging Bitcoin's proven security model.

[![GitHub license](https://img.shields.io/github/license/hemilabs/heminetwork)](https://github.com/hemilabs/heminetwork/blob/main/LICENSE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the license in the README so this just added clutter.

@@ -1,6 +1,9 @@
# ⚡️ The Hemi Network

Hemi is an EVM-compatible L2 blockchain that combines the security of Bitcoin with the programmability of Ethereum.
Hemi is an EVM-compatible L2 blockchain that combines the security of Bitcoin with the programmability of Ethereum. It provides a robust, scalable solution for decentralized applications while leveraging Bitcoin's proven security model.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just adding marketing terms and does add to the readability or info in the readme.

@@ -33,6 +36,14 @@ Hemi is an EVM-compatible L2 blockchain that combines the security of Bitcoin wi

---

## 🌟 Key Features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just makes the doc longer.

@@ -227,6 +235,48 @@ clean environment. It can be omitted.

---

## 🤝 Contributing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a contributing doc linked.


---

<div align="center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need html formatting or non-ascii here.


<div align="center">
<p>Built with ❤️ by the Hemi Labs team and contributors.</p>
<p>© 2024 Hemi Labs. All Rights Reserved.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong year.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the contents of this repository are MIT Licensed, not ARR.

Comment on lines +268 to +271
- [Official Documentation](https://docs.hemi.network)
- [API Reference](https://api.hemi.network)
- [Community Forum](https://forum.hemi.network)
- [Discord Community](https://discord.gg/hemi)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these links are exist, and our Discord server is hemixyz, not hemi.

@jcvernaleo
Copy link
Contributor

Closing this since basically everything would need to be changed. Feel free to open an new PR with a more minimal set of fixes based on our comments here if you want.

@jcvernaleo jcvernaleo closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants