Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): migrate to astro v5 #518

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore(deps): migrate to astro v5 #518

wants to merge 10 commits into from

Conversation

hendriknielaender
Copy link
Owner

@hendriknielaender hendriknielaender commented Dec 16, 2024

Current bugs:

  • [category]/[...page].astro:48:21 - undefined is not an object (evaluating 'page.currentPage')

@hendriknielaender hendriknielaender self-assigned this Dec 16, 2024
@hendriknielaender hendriknielaender added the enhancement New feature or request label Dec 23, 2024
@hendriknielaender
Copy link
Owner Author

@flyck when you have time, would be cool if we move to v5 :)

Some little bugs needs to be fixed before we can move here.

@flyck
Copy link
Collaborator

flyck commented Jan 14, 2025

Noticed a few things:

  • release post mentions an official image component. Tried to switch but that doesnt support the aspectRatio which we need. Would need a deeper look so we can switch
  • We have some unused code like the inbuild splitbee analytics or the post categories functionality which we don't use. I guess we dont need the categories, right?
  • Upstream repo has some more goodies which could improve the codebase and could be worth a look.

Other than that this works locally, I visited all major pages and checked also for console errors. 👍🏻

@flyck flyck marked this pull request as ready for review January 14, 2025 20:08
@flyck
Copy link
Collaborator

flyck commented Jan 14, 2025

Instead of using as Post[] we can also switch to the upstream typescript utils. These have kind of a big diff though, so I would do this another day

https://github.com/onwidget/astrowind/blob/bbcbde87c92a631073e812bd672209effc49abc9/src/utils/blog.ts

@flyck
Copy link
Collaborator

flyck commented Jan 15, 2025

Adapting the types is not trivial for an evening job lul. Created a seperate PR: #527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants