-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile, Man-pages and some cleaning #68
base: master
Are you sure you want to change the base?
Conversation
…ce in /usr/local/bin and the settings file is placed in /usr/local/etc/usbkill as per 'man hier'
…ow placed in /usr/local/etc/usbkill as per 'man hier'
Thanks! But, I have two issues that prevent me from accepting this commit into master:
|
Hello, There is no problem to list me into the AUTHOR file but I think it's a bit useless as the commits are already speaking by themselves. Regards, Sent from my iPhone
|
Well, we're going to have to agree to disagree about the Makefile, but it's you're project. If you don't want it, I'll remove it. About the settings file, I'd still recommend having it in /usr/local/etc and then symlinking it in /etc. That way you get to reference /etc/usbkill/settings.ini in your code and be POSIX compliant. POSIX specifies that /etc is for system wide configuration and /usr/local/(etc...) is for local data specific to the host. It would also make the project more compliant towards the hier(7) page. About the second, for me it's clear that people would want to be listed as contributors, as they already are listed, as @pwnsdx mentioned, in the commits and under "contributors on GitHub. I'll remove people, and have them enter it themselves. I'll make a new commit later tonight. |
A makefile for fast & easy install (and removal) of usbkill, it's settingsfile and 2 man pages explaining usbkill and it's settingsfile.
I also created a AUTHORS file with a list of everyone that was listed as cotnributors.
Last but not least, I trimmed the usbkill.py code so there's noi longer any unneeded trailing spaces.