Skip to content

Commit

Permalink
Gluecodium.kt: validate functions just once
Browse files Browse the repository at this point in the history
'LimeFunctionsValidator' uses 'typeRef' member while performing validation.
Therefore, it shall be present only in 'getTypeRefDependentValidators()'.

However, it is present also in 'getIndependentValidators()' which means,
that Gluecodium validates functions twice.

The investigation of GIT history revealed that addition of functions
validator to 'independent validators' list was done accidentally.

This change ensures, that the mentioned validator is run only once.

Signed-off-by: Patryk Wrobel <[email protected]>
  • Loading branch information
pwrobeldev committed Nov 25, 2024
1 parent b516e6b commit f9b1224
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions gluecodium/src/main/java/com/here/gluecodium/Gluecodium.kt
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class Gluecodium(
{ LimeStructsValidator(limeLogger, gluecodiumOptions.isStrictMode).validate(it) },
{ LimeSerializableStructsValidator(limeLogger).validate(it) },
{ LimeInheritanceValidator(limeLogger).validate(it) },
{ LimeFunctionsValidator(limeLogger).validate(it) },
{ LimeFunctionsValidator(limeLogger, generatorOptions).validate(it) },
{ LimeOptimizedListsValidator(limeLogger).validate(it) },
{ LimeFieldConstructorsValidator(limeLogger).validate(it) },
{ LimeValuesValidator(limeLogger).validate(it) },
Expand All @@ -193,7 +193,6 @@ class Gluecodium(
{ LimeConstantRefsValidator(limeLogger).validate(it) },
{ LimeExternalTypesValidator(limeLogger).validate(it) },
{ LimePropertiesValidator(limeLogger).validate(it) },
{ LimeFunctionsValidator(limeLogger, generatorOptions).validate(it) },
{ LimeSkipValidator(limeLogger).validate(it) },
{ LimeAsyncValidator(limeLogger).validate(it) },
)
Expand Down

0 comments on commit f9b1224

Please sign in to comment.