Dart: fix problems with default values that use collection types #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrect code This change is used to showcase the invalid behavior of Dart generator. Usage of 'PositionalDefaults' annotation combined with nullable collection field that has 'null' default value yields the code that does not compile. The generator blindly applies 'const' keyword before the default value for collections. This is done in 'DartStructConstructors.mustache' depending on the field LIME type. However, a special 'null' value is not taken into account. It seems to be invalid. Signed-off-by: Patryk Wrobel <[email protected]>
This change is used to showcase the invalid behavior of Dart generator. Usage of 'Immutable' annotation combined with collection fields that have default values yields the code that does not compile. The generator does not apply 'const' keyword before the calls to constructors of collections. It is required, because the constructor of 'Immutable' structure is marked as 'const'. The same happens in an explicit field constructor is used. Because of 'Immutable' usage it is marked as a const, but the default values are not initialized with values prepended by 'const'. Signed-off-by: Patryk Wrobel <[email protected]>
…lections This change adjusts the logic that prepends 'const' keyword in 'DartStructConstructors.mustache' to avoid adding 'const' keyword when the default value is null. It was required to generate the code that compiles. Without the adjustment the functional test did not compile. Signed-off-by: Patryk Wrobel <[email protected]>
This change adjusts 'DartStructConstructors.mustache' to ensure that 'const' keyword is prepended to constructors of default values that are collections when 'Immutable' annotation is used. It was required because the constructors of 'Immutable' structures are always const. To initialize the default values const values are needed. Signed-off-by: Patryk Wrobel <[email protected]>
Describe implemented bug fix related to missing/superflous const keyword usage in constructors when annotations were specified. Signed-off-by: Patryk Wrobel <[email protected]>
|
Note for reviewers:
|
Hsilgos
approved these changes
Nov 21, 2024
pwrobeldev
deleted the
pwrobeldev/handling-of-default-value-of-nullable-collections-in-dart
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series fixes problems that occur when either
@Immutableor
@PositionalDefaultsannotation is used in combination withcollection types.
--------
@PositionalDefaults--------The usage of 'PositionalDefaults' annotation
combined with nullable collection field that has 'null'
default value yields the code that does not compile.
The generator blindly applies 'const' keyword before
the default value for collections. A special 'null' value is
not taken into account.
--------
@Immutable--------Usage of 'Immutable' annotation combined
with collection fields that have default values yields the
code that does not compile.
The generator does not apply 'const' keyword before the calls
to constructors of collections. It is required, because the
constructor of 'Immutable' structure is marked as 'const'.
The same happens when an explicit field constructor is used.
Because of 'Immutable' usage it is marked as a const, but
the default values are not initialized with values prepended
by 'const'.
-------- Content of change --------
the invalid behavior.
correctly prepend 'const' keyword when needed and to treat
'null' as it should be treated.