Dart: fix problems with default values that use immutable types #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is used to showcase the invalid behavior of Dart generator. Usage of 'Immutable' annotation combined with field, which has default value and uses immutable struct type yields the code that does not compile. The generator does not apply 'const' keyword before the calls to constructors of structures. It is required, because the constructor of 'Immutable' structure is marked as 'const'. Signed-off-by: Patryk Wrobel <[email protected]>
…not compile This change is used to showcase the invalid behavior of Dart generator. Usage of 'PositionalDefaults' annotation combined with field, which has default value and uses immutable struct type yields the code that does not compile. The generator does not apply 'const' keyword before the calls to constructors of structures. It is required, because the value of optional parameters must use 'const' keyword. Signed-off-by: Patryk Wrobel <[email protected]>
This change ensures that the required 'const' keyword is prepended to constructor call when needed in the case of 'DartStructConstructors.mustache' and usage of struct types for fields with default values. Signed-off-by: Patryk Wrobel <[email protected]>
This commit describes the implemented bug-fix Signed-off-by: Patryk Wrobel <[email protected]>
Hsilgos
approved these changes
Nov 26, 2024
pwrobeldev
deleted the
pwrobeldev/immutable-struct-field-with-default-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series fixes problems that occur when either 'Immutable'
or 'PositionalDefaults' annotation is used in combination with
immutable types that have default value.
In both cases the resulting code did not contain the required
'const' keyword.
-------- Content of change --------
the invalid behavior.
correctly prepend 'const' keyword when needed for immutable
struct fields.