Dart: do not generate redundant import for external constants #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces usage of constants that use a type, which is external. As we can see an unneeded import is present in 'external_dart_constants.dart' file: `package:library/src/smoke/rectangle_int_.dart` is not used, but it is imported. Signed-off-by: Patryk Wrobel <[email protected]>
The same file is generated in functional tests. It build. This will be used as a checkpoint to confirm that the code builds, when the redundant import is removed. Signed-off-by: Patryk Wrobel <[email protected]>
This change adjusts 'DartImportResolver' to import only neccessary file, when a type, which uses external one is specified for constants. Signed-off-by: Patryk Wrobel <[email protected]>
Signed-off-by: Patryk Wrobel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
----- Motivation -----
The generator added redundant import when external type
was used to specify constants. This resulted in linter error
unused_import.----- Content of the change -----
This change adjusts 'DartImportResolver' to import
only necessary file, when a type, which uses external
one is specified for constants.
First two commits shows the invalid behavior in smoke
and functional tests. The latter is used to ensure, that
the code builds when the redundant import is removed.
The third commit contains the actual fix (one-line).