Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apple CI jobs, skip boost compile warning #1563

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

ystefinko
Copy link
Collaborator

@ystefinko ystefinko commented Nov 11, 2024

According to updates on images: macos-12 deprecation we should use macos-13 and Xcode 14.3 as the lowest versions in CI validation.
Also, add х86_64 macos-13 image with job separately, while other images
are by default on ARM.
Additional compiler options are related boost internal warnings
on newer xcodes.
Add more MacOS jobs to cover more combinations: MacOS-Xcode.

Relates-TO: DATASDK-47

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.39%. Comparing base (aac3dd4) to head (8a9c463).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1563      +/-   ##
==========================================
+ Coverage   81.36%   81.39%   +0.03%     
==========================================
  Files         345      345              
  Lines       13511    13512       +1     
  Branches     1458     1458              
==========================================
+ Hits        10992    10997       +5     
+ Misses       1922     1919       -3     
+ Partials      597      596       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ystefinko ystefinko force-pushed the macos-ci-upd branch 5 times, most recently from 9e83ef5 to 8fa5ca7 Compare November 12, 2024 08:41
According to updates on images: macos-12 deprecation we
should use macos-13 and Xcode 14.3 as the lowest versions
fo CI validation.
Also, add ARM macos-14 image with separate script and job.

Relates-To: DATASDK-47

Signed-off-by: Yaroslav Stefinko <[email protected]>
@rustam-gamidov-here
Copy link
Collaborator

It probably worth a comment that additional compiler options are related boost internal warnings on newer xcodes.
Could be in the script or in the PR description to be visible in git history.

@ystefinko ystefinko changed the title Update MacOS and iOS CI jobs Update Apple CI jobs, skip boost compile warning Nov 12, 2024
@ystefinko ystefinko merged commit 0cd2288 into master Nov 12, 2024
24 checks passed
@ystefinko ystefinko deleted the macos-ci-upd branch November 12, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants