WIP Add cache statistics #812
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykhailo Kuchma <[email protected]>
andescu
suggested changes
Apr 28, 2020
Comment on lines
+141
to
+146
| /** | ||
| * @brief Retrieve the accumulated statistics of the cache instance. | ||
| * | ||
| * @return Statistics structure. | ||
| */ | ||
| virtual Statistics GetStatistics() const { return Statistics{}; } |
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
========================================
- Coverage 78.7% 78.7% -0.0%
========================================
Files 292 292
Lines 9928 9941 +13
========================================
+ Hits 7817 7823 +6
- Misses 2111 2118 +7
Continue to review full report at Codecov.
|
HalynaDumych
requested changes
Aug 19, 2020
| * @brief The accumulated statistics for the cache. | ||
| */ | ||
| struct Statistics { | ||
| /// The number of bytes written to disk cache with Put methods. |
There was a problem hiding this comment.
Suggested change
| /// The number of bytes written to disk cache with Put methods. | |
| /// The number of bytes written to the disk cache with the `Put` methods. |
| struct Statistics { | ||
| /// The number of bytes written to disk cache with Put methods. | ||
| uint64_t bytes_written; | ||
| /// The number of bytes read from disk cache with Get methods. |
There was a problem hiding this comment.
Suggested change
| /// The number of bytes read from disk cache with Get methods. | |
| /// The number of bytes read from the disk cache with the `Get` methods. |
| uint64_t bytes_written; | ||
| /// The number of bytes read from disk cache with Get methods. | ||
| uint64_t bytes_read; | ||
| /// The number of bytes removed from disk cache with Remove method. |
There was a problem hiding this comment.
Suggested change
| /// The number of bytes removed from disk cache with Remove method. | |
| /// The number of bytes removed from the disk cache with the `Remove` methods. |
| uint64_t bytes_read; | ||
| /// The number of bytes removed from disk cache with Remove method. | ||
| uint64_t bytes_removed; | ||
| /// The number of bytes evicted from disk cache. |
There was a problem hiding this comment.
Suggested change
| /// The number of bytes evicted from disk cache. | |
| /// The number of bytes evicted from the disk cache. |
| uint64_t bytes_removed; | ||
| /// The number of bytes evicted from disk cache. | ||
| uint64_t bytes_evicted; | ||
| /// The size of content stored in mutable disk cache. |
There was a problem hiding this comment.
Suggested change
| /// The size of content stored in mutable disk cache. | |
| /// The size of content stored in the mutable disk cache. |
| @@ -121,6 +137,13 @@ class CORE_API KeyValueCache { | |||
| * @return True if the values are removed; false otherwise. | |||
| */ | |||
| virtual bool RemoveKeysWithPrefix(const std::string& prefix) = 0; | |||
|
|
|||
| /** | |||
| * @brief Retrieve the accumulated statistics of the cache instance. | |||
There was a problem hiding this comment.
Suggested change
| * @brief Retrieve the accumulated statistics of the cache instance. | |
| * @brief Gets the accumulated statistics of the cache instance. |
| /** | ||
| * @brief Retrieve the accumulated statistics of the cache instance. | ||
| * | ||
| * @return Statistics structure. |
There was a problem hiding this comment.
Suggested change
| * @return Statistics structure. | |
| * @return The statistics structure. |
| @@ -149,6 +149,9 @@ class CORE_API DefaultCache : public KeyValueCache { | |||
| */ | |||
| bool RemoveKeysWithPrefix(const std::string& prefix) override; | |||
|
|
|||
| /// Implements GetStatistics method of KeyValueCache. | |||
There was a problem hiding this comment.
Suggested change
| /// Implements GetStatistics method of KeyValueCache. | |
| /// Implements the `GetStatistics` method of `KeyValueCache`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykhailo Kuchma [email protected]