feat(int tests): add "incorrect checksum" scenario #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-alkov
requested review from
brunoapimentel,
eskultety,
taylormadore,
ejegrova and
slimreaper35
|
please change the jira name to: STONEBLD-1895 |
ejegrova
approved these changes
Dec 19, 2023
|
The test LGTM 👍 nit: The only thing I might suggest is to update the README header on the test repo branch to match the test name |
Done |
ben-alkov
force-pushed
the
feat-int-test-add-incorrect-checksum
branch
from
97e86b4 to
a155b84
Compare
taylormadore
approved these changes
Jan 2, 2024
tests/integration/test_yarn.py
Outdated
| pytest.param( | ||
| utils.TestParameters( | ||
| repo="https://github.com/cachito-testing/cachi2-yarn-berry.git", | ||
| ref="dcb16b5931a89ac642be2dcf9886e148a905bea4", |
There was a problem hiding this comment.
nit: Consider updating this ref to the latest on that branch so that it links to the updated README
brunoapimentel
approved these changes
Jan 3, 2024
STONEBLD-1895 Signed-off-by: Ben Alkov <[email protected]>
ben-alkov
force-pushed
the
feat-int-test-add-incorrect-checksum
branch
from
a155b84 to
383442a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test data (cachi2-yarn-berry, "incorrect-checksum" branch)
STONEBLD-1895
Signed-off-by: Ben Alkov [email protected]
Maintainers will complete the following section
Docs updated (if applicable)Docs links in the code are still valid (if docs were updated)Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)