Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRIBUTING] Add a note on the 'hack/mock-unittest-data' directory and how to re-generate mock unit test data #777

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

eskultety
Copy link
Member

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Docs updated (if applicable)
  • Docs links in the code are still valid (if docs were updated)

Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:

@eskultety eskultety mentioned this pull request Jan 6, 2025
4 tasks
CONTRIBUTING.md Outdated Show resolved Hide resolved
@eskultety eskultety force-pushed the contributing-mention-hack branch from c86b602 to 7fd8026 Compare January 6, 2025 16:21
We've lacked any kind of mention of the hack directory and its purpose.

Signed-off-by: Erik Skultety <[email protected]>
@eskultety eskultety force-pushed the contributing-mention-hack branch from 7fd8026 to 083bd24 Compare January 6, 2025 16:21
@eskultety eskultety added this pull request to the merge queue Jan 6, 2025
Merged via the queue into hermetoproject:main with commit 655d51a Jan 6, 2025
15 checks passed
@eskultety eskultety deleted the contributing-mention-hack branch January 6, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants