[test] Add nox to our dev dependencies and therefore to requirements-extras.txt #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskultety
force-pushed
the
nox-to-requirements
branch
2 times, most recently
from
2a6a9a5 to
ed1f062
Compare
slimreaper35
approved these changes
Jan 29, 2025
Based on the background from commit 67d5143 the '--allow-unsafe' flag was needed by pip-compile for both requirements.txt and requirements-extras.txt solely because of setuptools and because requirements.txt has been pulled in by requirements-extras.txt directly. Our direct dependency on setuptools was dropped in commit f21f732 but the flag itself was only removed from the requirements.txt generator CLI of pip-compile but not from the requirements-extras.txt one. The latter was then removed later by accident in commit d42d95e which converted our tox usage to nox. In any case, this commit is proposed standalone to shed a bit more light on the background of '--allow-unsafe' usage in our pip-compile invocation which doesn't seem to be needed any longer. In case that need arises again, this commit can be referenced/blamed in the future as a knowledge base resource. Signed-off-by: Erik Skultety <[email protected]>
See previous commit for explanation on why this is no longer needed on our side and in fact hasn't been part of local development's setups for a while ever since we switched to nox. Signed-off-by: Erik Skultety <[email protected]>
We encourage developers to use nox as the local test automation tool, yet we don't install it by default as part of our dependencies, fix that. Signed-off-by: Erik Skultety <[email protected]>
eskultety
force-pushed
the
nox-to-requirements
branch
from
ed1f062 to
dd35bec
Compare
a-ovchinnikov
approved these changes
Jan 29, 2025
Merged
via the queue into
hermetoproject:main
with commit Jan 29, 2025
d4a77e1
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit 3/3.
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)