Report pip build dependencies in the SBOM #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoapimentel
changed the title
|
/retest |
a-ovchinnikov
approved these changes
Jan 29, 2025
7 tasks
|
/retest |
taylormadore
approved these changes
Jan 29, 2025
brunoapimentel
force-pushed
the
pip-build-deps
branch
from
9dca171 to
28bc742
Compare
eskultety
reviewed
Jan 30, 2025
| @@ -194,6 +194,10 @@ def fetch_pip_source(request: Request) -> RequestOutput: | |||
| if dependency["package_type"] == "wheel": | |||
| pip_package_binary = True | |||
|
|
|||
There was a problem hiding this comment.
Commit message nitpick:
s/declared as requirements_build_files/declared via the 'requirements_build_files' input JSON option
Cachi2's default approach to prefetching pip dependencies is to only download sdists. This means that all wheels will need to be compiled from source, which usually means that additional dependencies will be necessary during the build process. This patch prepares a property that will be used to indicate in the SBOM that a dependency was defined in a requirements_build_file. Signed-off-by: Bruno Pimentel <[email protected]>
brunoapimentel
force-pushed
the
pip-build-deps
branch
3 times, most recently
from
fa9294f to
fa61c89
Compare
slimreaper35
approved these changes
Feb 5, 2025
|
/retest |
Considering that the user configured his repository correctly, the only dependencies that should be present in files declared via the 'requirements_build_files' input JSON option are build dependencies. Having this info in the SBOM will help future security analysis perfomed on the built artifact. Signed-off-by: Bruno Pimentel <[email protected]>
brunoapimentel
force-pushed
the
pip-build-deps
branch
from
fa61c89 to
7433bbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering that the user configured his repository correctly, the only dependencies that should be present in files declared as requirements_build_files are build dependencies. Having this info in the SBOM will help future security analysis perfomed on the built artifact.
Since there is no default CycloneDx property for pip build dependencies, we're creating a custom Cachi2 one.
Maintainers will complete the following section