Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More performant and idiomatic versions of string substitution #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

More performant and idiomatic versions of string substitution #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions addons/com.heroiclabs.nakama/Satori/SatoriAPI.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,8 +1300,7 @@ class ApiClient extends RefCounted:
if try_refresh.is_exception():
return SatoriAsyncResult.new(try_refresh.get_exception())
await p_session.refresh(try_refresh)
var urlpath : String = "/v1/message/{id}"
urlpath = urlpath.replace("{id}", SatoriSerializer.escape_http(p_id))
var urlpath : String = "/v1/message/%s" % SatoriSerializer.escape_http(p_id)
var query_params = ""
var uri = "%s%s%s" % [_base_uri, urlpath, "?" + query_params if query_params else ""]
var method = "DELETE"
Expand All @@ -1327,8 +1326,7 @@ class ApiClient extends RefCounted:
if try_refresh.is_exception():
return SatoriAsyncResult.new(try_refresh.get_exception())
await p_session.refresh(try_refresh)
var urlpath : String = "/v1/message/{id}"
urlpath = urlpath.replace("{id}", SatoriSerializer.escape_http(p_id))
var urlpath : String = "/v1/message/%s" % SatoriSerializer.escape_http(p_id)
var query_params = ""
var uri = "%s%s%s" % [_base_uri, urlpath, "?" + query_params if query_params else ""]
var method = "PUT"
Expand Down