[Stacked] Proof of concept bullet stream global functions #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making progress towards closing #762. Doesn't quite do everything, but does a lot.
schneems
added
the
skip changelog
schneems
force-pushed
the
schneems/bs_output
branch
from
e2f44ec to
246d238
Compare
This is a bit of an open question on the best place to print to by default. Stderr is for humans and stdout is for machines (pipes). All of our data is to the user so I picked the global output to be stderr. IDK if there's any practical problem with picking on or the other. But it did cause all these tests to fail. This commit fixes it and opens up the conversation/question. We also have the ability to set the output location globally at the start of each buildpack.
schneems
force-pushed
the
schneems/bs_output
branch
from
4c8f9d7 to
4bba0ad
Compare
schneems
force-pushed
the
schneems/bs_output
branch
from
05e6858 to
ac4f3c8
Compare
Attempting to show the guide name in the title without having to click through.
schneems
force-pushed
the
schneems/bs_output
branch
from
ac4f3c8 to
e8b6703
Compare
All buildpacks now use the new buildpack logging output instead of libherokubuildpack's old log functions
The previous code reported the status but not always the output (when commands are hidden).
schneems
force-pushed
the
schneems/bs_output
branch
from
6d07434 to
5a382d9
Compare
schneems
force-pushed
the
schneems/bs_output
branch
from
5a382d9 to
3b7cfdc
Compare
schneems
force-pushed
the
schneems/bs_output
branch
from
3b7cfdc to
7be0377
Compare
|
This would now close out #762 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept to see how difficult slotting in the bullet stream functions and fun run for the JVM buildpack would be.
This preserves
Into<BuildpackOutputText>but replaces allprintln!functionality. Thetrack_timinginterface was changed as well as the command execution function. It could be removed all-together now as it's not doing much.