-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM support for resolve-version #1321
base: main
Are you sure you want to change the base?
Conversation
@mlarraz thanks for the PR! I won't be able to fully review this until sometime next week due to other priorities but it looks like a good first step in addressing #1268. As for the cross-compilation of the
And you're right, the vendored |
Thanks, I will work on adding the binaries. I noticed a previous commit referenced compressing the yq binaries, but didn't go into detail. It doesn't look like it was using tar or some other container as the files are still directly executable. |
d6bccaf
to
40cee2d
Compare
Ugh, this fell off my radar as there's no priority to support ARM for our classic buildpacks. I'm going to convert this PR to a draft for now with the hope of returning to it. |
resolve-version-linux
andresolve-version-darwin
toresolve-version-linux-x64
andresolve-version-darwin-x64
get_cpu()
bash function to support ARM (and drop support for i686)get_platform()
function instead ofget_os()
to determine filenameI have not actually managed to build the new binaries myself as I'm not very experienced with Rust, but hoping somebody can help out.
I noticed there's a similar thing happening for
yq
but I didn't see any code handling the vendoring so I assume it was done manually. Presumably it will need ARM versions as wellThis is meant to fix #1268