Support for Notebook 7 and Jupyter Lab #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, add jupyter lab to requiremnts.txt
…s...eventually replace with Heroku fork) that fixes pgcontents implementation of ContentsManager class to be compatible with Jupyter Lab
… is being deprecated)
…h application to launch, and add JUPYTER_NOTEBOOK_ARGS for additional command line options.
Jupyter lab
hillarysanders
requested changes
Jan 7, 2025
hillarysanders
approved these changes
Jan 17, 2025
README.md
Outdated
| @@ -46,6 +48,7 @@ heroku stack:set heroku-24 --app $APP_NAME | |||
|
|
|||
| # Set your required config variable: | |||
| heroku config:set JUPYTER_NOTEBOOK_PASSWORD=$JUPYTER_NOTEBOOK_PASSWORD -a $APP_NAME | |||
| heroku congif:set JUPYTER_NOTEBOOK_OR_LAB=$JUPYTER_NOTEBOOK_OR_LAB -a $APP_NAME | |||
There was a problem hiding this comment.
congif - misspelled
|
I fixed the typo, but I don't have permissions to merge.
…On Fri, Jan 17, 2025 at 8:42 AM Hillary Sanders ***@***.***> wrote:
***@***.**** approved this pull request.
Sweet looks great - just need to fix the congif in the README - can you
fix and then land?
------------------------------
In README.md
<#11 (comment)>:
> @@ -46,6 +48,7 @@ heroku stack:set heroku-24 --app $APP_NAME
# Set your required config variable:
heroku config:set JUPYTER_NOTEBOOK_PASSWORD=$JUPYTER_NOTEBOOK_PASSWORD -a $APP_NAME
+heroku congif:set JUPYTER_NOTEBOOK_OR_LAB=$JUPYTER_NOTEBOOK_OR_LAB -a $APP_NAME
congif - misspelled
—
Reply to this email directly, view it on GitHub
<#11 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUV3HQXFYMAKPCOZVGYUAZT2LEXI3AVCNFSM6AAAAABUYSE3B2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNJZGQ3TEOBXGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated repository now launches either Jupyter Notebook 7 or Jupyter Lab on start up (based on env variable JUPYTER_NOTEBOOK_OR_LAB).
This PR includes breaking changes: