Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Commit

Permalink
Version 1.3.1 (#25)
Browse files Browse the repository at this point in the history
Smaller bugfixes
* removed typo in `isQualified()` method which was blocking all_corporations affiliation.
* removed some typos in changelog
* fixed detaching-error in `beforeStart()` method
* added SeAT Group as Manager in panel-footer.
  • Loading branch information
herpaderpaldent authored Sep 12, 2018
1 parent 0a493b9 commit e02c5ff
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
11 changes: 9 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# Version 1.3.1
Smaller bugfixes
* removed typo in `isQualified()` method which was blocking all_corporations affiliation.
* removed some typos in changelog
* fixed detaching-error in `beforeStart()` method
* added SeAT Group as Manager in panel-footer.

# Version 1.3.0
This update is brought to you because and thanks to mmolitor87 & Vojax. Both had very valuable input on how to make SeAT-Groups even better. Thank you for being patient with me, and keep your feedback flowing.

Expand All @@ -11,8 +18,8 @@ This update is brought to you because and thanks to mmolitor87 & Vojax. Both had
* Attempting to modify LogController to resolve an issue with too large DBs
* `onFail` now correctly reports to log what went wrong

ATTENTION: Managers need now to be extra careful when pruging members and make sure they purge all characters from a user_group, whereas before everything was bound to the main_character.
If a user lacks of at least 1 character in his user_group which qualifies in respective to your configurated affiliation he will get removed from the SeAT group. This means the user will lose every role bound to this SeAT Group and needs to apply/opt-in again.
ATTENTION: Managers need now to be extra careful when purging members and make sure they purge all characters from a user_group, whereas before everything was bound to the main_character.
If a user lacks of at least 1 character in his user_group which qualifies in respective to your configured affiliation he will get removed from the SeAT group. This means the user will lose every role bound to this SeAT Group and needs to apply/opt-in again.


# Version 1.2.0
Expand Down
2 changes: 1 addition & 1 deletion src/Jobs/GroupSync.php
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public function beforeStart()
// take away all roles
$this->group->roles()->sync([]);
Seatgroup::all()->each(function ($seatgroup) {
$seatgroup->member->detach($this->group->id);
$seatgroup->member()->detach($this->group->id);
});

SeatgroupLog::create([
Expand Down
3 changes: 2 additions & 1 deletion src/Models/SeatGroup.php
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ public function isQualified(Group $group)
{

$action = new GetCurrentAffiliationAction;
if ($this->all_coporation)

if ($this->all_corporations)
return true;

$affiliations = collect($action->execute(['seatgroup_id' => $this->id]));
Expand Down
2 changes: 1 addition & 1 deletion src/resources/views/partials/managed-group.blade.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

</div>
<div class="panel-footer">
Managers: {{$seatgroup->manager->map(function($user) { return $user->main_character->name; })->implode(', ')}}
Managers: {{$seatgroup->manager->map(function($user) { return $user->main_character->name; })->concat($seatgroup->children->map(function($children) { return $children->name; }))->implode(', ')}}

@includeWhen($seatgroup->isManager(auth()->user()->group) || auth()->user()->hasSuperUser(),'seatgroups::partials.manager-modal')

Expand Down

0 comments on commit e02c5ff

Please sign in to comment.