Enhancements #1
Open
Enhancements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Icosa Developer <[email protected]>
added some example logging Signed-off-by: Icosa Developer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm submitting this pull request for the enhanced logging and error trapping I've implemented.
I've added logging to the HTTP requests in ROS namely [get,patch,delete,etc]_as() as well as some error trapping.
The requests library also had the handy method response.raise_for_status() to raise some HTTP errors automatically which I added during the logging phase.
I added a delete_as() method since the session.delete you were using wasn't getting the URL from the ROS class, self.url was just blank and was causing some exceptions and self.filename only had the API portion of the call.
The readme shows some of the basic logging that can be done outside of the internal logging.
Icosa.