Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing notes #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

oswalpalash
Copy link
Contributor

No description provided.

@@ -13,7 +13,7 @@

- lenovo chromebook n23 - hana
- acer chromebook r13 - elm
- lenovo chromebook 300e (mt8173 version) - hana
- lenovo chromebook 300e (mt8173 version) - hana (tested with kernel 6.1.0-stb-mt7+)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would prefer not to add kernel versions here - the tested section is more ment to distinguish the devices already at least tested once successfully from the ones which nobody every tested at all so far ... once they are working they usually remain working and if not its worth to open a github issue for that as it would be a regression

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I will address it.

@@ -45,6 +45,7 @@
- with v5.10 it works fine (console and xorg) with https://github.com/hexdump0815/imagebuilder/blob/main/systems/chromebook_oak/extra-files/usr/lib/systemd/system-sleep/mrvl-reload - so all images starting with version 210724-02 should be fine
- with v5.11+ it is broken as the display does not come back after resume - see todo
- with v5.18 it is working again, only display sleep is broken and being worked around by special power management settings in the image
- with v6.1.0 it is working
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the display blanking really working for you with v6.1? - when i tested it last with my elm it still did not work ... currently there is a workaround in place in the settings -> power manager which simply reduces the brightness to only 1% after two minutes (which looks nearly like a proper display sleep state) but does not put the display into proper sleep state as - at least for me - it did not come back from there even with v6.1 ... the test is to enable the regular display blanking options in the power manager display settings and verify that the display comes back properly from a real display sleep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I had last looked at it, things were still working. I will test again later today and confirm.

@hexdump0815
Copy link
Owner

... besides what i wrote in my comments: thanks a lot for the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants