-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ucm & libinput config for trogdor-coachz #201
base: main
Are you sure you want to change the base?
Conversation
thanks a lot for this pr - i'll have a look at it during the next days |
i just wanted to note that i did not forget about this pr, i'm just having very little time right now, but i'll come back to it (and other stuff) for sure when more time will be available |
This part doesn't really explain why UCM configs in this PR conflict with upstream UCM, it just points to some files and commits. It is okay if you don't know it yet, but the first part of handling this would be to figure out why there is a conflict in the first place. Is it because there are different devices using the same sound card name, but having different audio configuration? does Also, it is better to submit these changes to https://github.com/alsa-project/alsa-ucm-conf to make this work available for other projects and reduce amount of configs (thus reducing maintenance burden) here |
if no, we can make different ucm configuration depending on device-tree compatible like here https://gitlab.com/postmarketOS/pmaports/-/blob/1f86677848a69f26ba60ec46b2a58b7283e7dead/device/community/alsa-ucm-conf-google-kukui/mt8183_mt6358_HiFi.conf#L36-40. You can figure out your compatible strings with
|
Sorry, I forgot to mention that I've sent a PR upstream, if I get any updates on that I will update this PR accordingly.
Regarding the conflict, the commit here symlinks To enable my changes with current imagebuilder setup, we wouldn't really need to do device detection in UCM imo, we can just move the ucm config to be inline with imagebuilder's setup (/usr/share/alsa/ucm2/SC7180 would have ucm for both |
Update: the alsa-ucm PR has been merged upstream |
As discussed in #44, this will add the ucm and libinput quirks to extra-files for trogdor.
Libinput changes:
Alsa UCM: