-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: joinPath() #230
base: master
Are you sure you want to change the base?
feat: joinPath() #230
Conversation
/* If the joined path string is a zero-length string, then '.' will be returned, | ||
representing the current working directory. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar behaviour as path.join()
path.resolve() is work? |
I mean this for now, need to fixed unit test, ready for review. |
Recently I have found a package on npm: https://npm.im/url-join Have a look? |
See also hexojs/hexo#5457 |
I think it should be implemented based on path or any other module instead of string concatenation. |
Yes, maybe |
ref: hexojs/hexo#4479
this enhances
path.join()
to convert slash, but thisjoinPath()
doesn't resolve '../' yet.