refactor: migrate typescript #5092

stevenjoezhang · 2022-11-01T16:46:04Z

Pending fix: missing types hexo-fs#109
Pending refactor: prepare for migration to typescript #5094
Pending refactor highlight: add extend api for highlight #5095
Pending fix inaccurate types hexo-util#294

What does it do?

Issue resolved: #4136

Screenshots

Pull request tasks

Add test cases for the changes.
Passed the CI test.

github-actions · 2022-11-01T16:46:16Z

Publish flamegraph to https://8e7598eb556392deed9b692c4fef7bb5de22895e-16-hexo.surge.sh/flamegraph.html

.husky/pre-commit

yoshinorin · 2022-11-25T15:25:57Z

@stevenjoezhang
BTW, do you have any plans to merge current open PRs before merging this PR? As we know, other PRs will be difficult to merge if we merge this. I assume you re-opened other PRs for it problem.

stevenjoezhang · 2022-12-04T13:49:27Z

Yes, we need to do a lot of rebase before / after this PR merged

renbaoshuo · 2022-12-31T08:50:18Z

It seems some conflicts appeared after merging #5136.

yoshinorin · 2022-12-31T09:06:51Z

It seems some conflicts appeared after merging #5136.

Yes. We have to resolve conflicts every time after merging other PRs. Personally, I want to merge this PR prioritize over others and release v7.0.0. Of course, if we can merge (or reject) other PRs soon that is better. But I think it is difficult for us.

renbaoshuo · 2023-01-08T02:29:18Z

@hexojs/core

I think we should merge #4926 and #4560 before merging this PR so that we can include all of them in next major release.

In addition, we should close #3719 and apply prettier after merging this PR.

yoshinorin · 2023-02-15T14:09:02Z

@stevenjoezhang
I added some commits for the success build (not yet completed). Today I read the current branch's source code. I'm not familiar with TS but I assume we have to spend many rewrites & much time to migrate TS. So, I think we should use @ts-ignore for migrate to TS once. After merge this PR we remove @ts-ignore step by step.

How do you think?
Thanks :)

SukkaW · 2023-02-15T15:25:04Z

I added some commits for the success build (not yet completed). Today I read the current branch's source code. I'm not familiar with TS but I assume we have to spend many rewrites & much time to migrate TS. So, I think we should use @ts-ignore for migrate to TS once. After merge this PR we remove @ts-ignore step by step.

IMHO we should prefer @ts-expect-error and as any (instead of @ts-ignore) whenever possible. But yes, we can always bring up type later.

coveralls · 2023-03-07T03:39:46Z

Coverage: 98.635% (-0.05%) from 98.687% when pulling 2749b23 on ts into 7edbf25 on master.

stevenjoezhang · 2023-03-07T16:11:02Z

It can be merged after fixing the eslint error

yoshinorin

LGTM 👍 ❤️ 🎉

It works correctly on my local machine. But, IMHO we should merge #5145 before merge this. Also #5153 and #4926? But, I don't know how to deal with #4926 🤔

stevenjoezhang · 2023-03-08T16:22:38Z

And we can release a candidate version like 7.0.0-rc.1 first, in case there are still some typescript issues that are not fully fixed

renbaoshuo · 2023-03-08T22:28:52Z

I noticed there are still some lint errors...

yoshinorin · 2023-03-09T12:36:23Z

And we can release a candidate version like 7.0.0-rc.1 first, in case there are still some typescript issues that are not fully fixed

So, our release plan is...

create v7.0.0 branch
merge ts branch into v7.0.0 branch
create a PR to v7.0.0 branch for release v7.0.0-rc1
release v7.0.0-rc1 from v7.0.0 branch
review perf(post): cache tags getter #5145, fix(post-asset): strip extensions better on permalink #5153 and Async rendering of tags within a post #4926
a. We will merge them into master branch or reject
merge v7.0.0 branch into master and resolve conflict if needed
a. if v7.0.0-rcN hasn't critical issues
release v7.0.0

Correct? And may we proceed this plan?

renbaoshuo · 2023-03-09T22:20:11Z

Hmm... It seems that there are anything wrong with our eslint rules?

stevenjoezhang · 2023-03-11T05:22:02Z

Seems that the eslint rules of js and ts are in conflict...

…rehouse.SchemaTypeMoment`

yoshinorin

#5092 (comment)

I pushed the v7.0.0 branch and changed the base branch from master to v7.0.0. We can merge this PR into v7.0.0 at any time.

I'm going to submit PR for v7.0.0-rc1 after merge this.

Thank you :)

yoshinorin · 2023-03-15T11:44:52Z

refs: #5176

stevenjoezhang commented Nov 1, 2022

View reviewed changes

.husky/pre-commit Outdated Show resolved Hide resolved

stevenjoezhang mentioned this pull request Nov 2, 2022

refactor: prepare for migration to typescript #5094

Merged

2 tasks

yoshinorin added this to the 7.0.0 milestone Nov 21, 2022

stevenjoezhang force-pushed the ts branch from 8061220 to e644f81 Compare November 24, 2022 07:30

stevenjoezhang mentioned this pull request Nov 24, 2022

fix inaccurate types hexojs/hexo-util#294

Merged

stevenjoezhang force-pushed the ts branch from 3f362ae to cd0d11a Compare December 15, 2022 03:48

renbaoshuo mentioned this pull request Jan 8, 2023

perf: run backtick code block in worker_threads #4368

Closed

2 tasks

stevenjoezhang force-pushed the ts branch from db1c359 to 784ecdf Compare February 11, 2023 18:13

yoshinorin force-pushed the ts branch from f8683e5 to cc3553b Compare February 28, 2023 13:05

stevenjoezhang marked this pull request as ready for review March 7, 2023 16:11

yoshinorin previously approved these changes Mar 8, 2023

View reviewed changes

renbaoshuo dismissed yoshinorin’s stale review via e6474a1 March 9, 2023 01:39

stevenjoezhang added 3 commits March 11, 2023 16:41

refactor: esm

8bf2b69

refactor: migrate typescript

0913097

update files

66c1a39

yoshinorin and others added 24 commits March 11, 2023 16:42

add secondary argument when create Permalink instance

d5eade2

specify eslint target directory

99a34a7

ignore two rules for testing

030da69

use @ts-expect-error for avoiding compile error

d222a0a

use any for avoiding compile error

ea02b4d

chore: add dist/ to .gitignore

4de2cec

test(eslint): update .eslintrc

e8de597

refactor: var to const

4a0520a

refactor: delete unnecessary 'use strict';

30c4136

test: use dist/modules/types/moment/SchemaTypeMoment instead of `wa…

fff9d9a

…rehouse.SchemaTypeMoment`

fix: export of processors

d1fa0f8

test: fix bind

6d1be46

test: fix processer

752665a

fix fs import

254f772

fix hexo-i18n and hexo-log

4d365b1

fix param order

755212a

build hexo in benchmark

4c717d2

fix eslint

fc1ecf4

fix export & drop travis

fd690a5

Update .husky/pre-commit

87216db

add spaces

36f3f8b

refactor: ts debounce fn

1d54103

fix: lint errors

a7d0eb6

fix: lint errors

2749b23

stevenjoezhang force-pushed the ts branch from e6474a1 to 2749b23 Compare March 11, 2023 08:43

yoshinorin changed the base branch from master to v7.0.0 March 14, 2023 10:20

yoshinorin approved these changes Mar 14, 2023

View reviewed changes

yoshinorin merged commit 148ed7c into v7.0.0 Mar 15, 2023

stevenjoezhang deleted the ts branch March 15, 2023 12:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: migrate typescript #5092

refactor: migrate typescript #5092

stevenjoezhang commented Nov 1, 2022 •

edited by renbaoshuo

Loading

github-actions bot commented Nov 1, 2022 •

edited

Loading

yoshinorin commented Nov 25, 2022

stevenjoezhang commented Dec 4, 2022

renbaoshuo commented Dec 31, 2022

yoshinorin commented Dec 31, 2022 •

edited

Loading

renbaoshuo commented Jan 8, 2023

yoshinorin commented Feb 15, 2023

SukkaW commented Feb 15, 2023

coveralls commented Mar 7, 2023 •

edited

Loading

stevenjoezhang commented Mar 7, 2023

yoshinorin left a comment •

edited

Loading

stevenjoezhang commented Mar 8, 2023

renbaoshuo commented Mar 8, 2023

yoshinorin commented Mar 9, 2023 •

edited

Loading

renbaoshuo commented Mar 9, 2023

stevenjoezhang commented Mar 11, 2023

yoshinorin left a comment •

edited

Loading

yoshinorin commented Mar 15, 2023

refactor: migrate typescript #5092

refactor: migrate typescript #5092

Conversation

stevenjoezhang commented Nov 1, 2022 • edited by renbaoshuo Loading

What does it do?

Screenshots

Pull request tasks

github-actions bot commented Nov 1, 2022 • edited Loading

yoshinorin commented Nov 25, 2022

stevenjoezhang commented Dec 4, 2022

renbaoshuo commented Dec 31, 2022

yoshinorin commented Dec 31, 2022 • edited Loading

renbaoshuo commented Jan 8, 2023

yoshinorin commented Feb 15, 2023

SukkaW commented Feb 15, 2023

coveralls commented Mar 7, 2023 • edited Loading

stevenjoezhang commented Mar 7, 2023

yoshinorin left a comment • edited Loading

Choose a reason for hiding this comment

stevenjoezhang commented Mar 8, 2023

renbaoshuo commented Mar 8, 2023

yoshinorin commented Mar 9, 2023 • edited Loading

renbaoshuo commented Mar 9, 2023

stevenjoezhang commented Mar 11, 2023

yoshinorin left a comment • edited Loading

Choose a reason for hiding this comment

yoshinorin commented Mar 15, 2023

stevenjoezhang commented Nov 1, 2022 •

edited by renbaoshuo

Loading

github-actions bot commented Nov 1, 2022 •

edited

Loading

yoshinorin commented Dec 31, 2022 •

edited

Loading

coveralls commented Mar 7, 2023 •

edited

Loading

yoshinorin left a comment •

edited

Loading

yoshinorin commented Mar 9, 2023 •

edited

Loading

yoshinorin left a comment •

edited

Loading