Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump hexo-front-matter from 4.0.0 to ^4.2.1 #5336

Merged
merged 3 commits into from
Oct 31, 2023
Merged

chore(deps): bump hexo-front-matter from 4.0.0 to ^4.2.1 #5336

merged 3 commits into from
Oct 31, 2023

Conversation

uiolee
Copy link
Member

@uiolee uiolee commented Oct 29, 2023 •
edited
Loading

The former one should be fixed in hexojs/hexo-front-matter#67, but since hexo-front-matter hasn't released a new version to include this change yet, we should still stick to v4.0.0 here to prevent type error.

Originally posted by @Pcrab in #5202 (comment)

What does it do?

bump hexo-front-matter from 4.0.0 to ^4.2.0

Require

dont merge this PR before:

@github-actions
Copy link

How to test

git clone -b front-420 https://github.com/uiolee/hexo.git
cd hexo
npm install
npm test

yoshinorin
yoshinorin reviewed Oct 31, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@uiolee uiolee changed the title chore(deps): fix hexo-front-matter to caret chore(deps): bump hexo-front-matter from 4.0.0 to ^4.2.0 Oct 31, 2023
yoshinorin
yoshinorin previously approved these changes Oct 31, 2023
View reviewed changes
@uiolee uiolee marked this pull request as draft October 31, 2023 10:12
@uiolee uiolee marked this pull request as ready for review October 31, 2023 11:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6706873263

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.535%
Totals Coverage Status
Change from base Build 6706758484: 0.0%
Covered Lines: 8997
Relevant Lines: 9039
💛 - Coveralls

@uiolee uiolee requested a review from yoshinorin October 31, 2023 13:13
yoshinorin
yoshinorin approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@uiolee uiolee merged commit d56529d into hexojs:master Oct 31, 2023
14 of 17 checks passed
@uiolee uiolee changed the title chore(deps): bump hexo-front-matter from 4.0.0 to ^4.2.0 chore(deps): bump hexo-front-matter from 4.0.0 to ^4.2.1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uiolee @coveralls @yoshinorin