refactor: migrate typescript #5417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b re/_test https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test |
Pull Request Test Coverage Report for Build 7998818473Details
💛 - Coveralls |
uiolee
reviewed
Feb 7, 2024
uiolee
previously approved these changes
Feb 7, 2024
| @@ -7,7 +7,8 @@ | |||
| "declaration": true, | |||
| "esModuleInterop": true, | |||
| "types": [ | |||
| "node" | |||
| "node", | |||
| "mocha" | |||
There was a problem hiding this comment.
It looks like it will load @types/mocha everywhere including src, I don't know if this is correct and acceptable
SukkaW
requested changes
Feb 8, 2024
| @@ -3,4 +3,3 @@ reporter: spec | |||
| ui: bdd | |||
| full-trace: true | |||
| exit: true | |||
| parallel: true | |||
There was a problem hiding this comment.
Any reason why parallel was disabled?
There was a problem hiding this comment.
I've tried keeping parallel, but then tests containing async on my computer throw exceptions, and I don't know why
There was a problem hiding this comment.
parallel makes it easier to make tests timeout in my experience
SukkaW
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Screenshots
Pull request tasks