Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor: backslashes on Windows (#5457)" #5481

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Apr 26, 2024

This reverts commit 80dafe2.

What does it do?

Fix hexojs/hexo-renderer-marked#281
Fix hexojs/hexo-renderer-marked#290

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

Copy link

How to test

git clone -b windows https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

coveralls commented Apr 26, 2024

Pull Request Test Coverage Report for Build 8881635399

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.478%

Totals Coverage Status
Change from base Build 8875175928: 0.0%
Covered Lines: 9339
Relevant Lines: 9388

💛 - Coveralls

@stevenjoezhang stevenjoezhang marked this pull request as ready for review April 29, 2024 15:57
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need v7.2.1? Or should we include this in v7.3.0? If we will release v7.2.1, I'll create a branch from v7.2.0.

@uiolee
Copy link
Member

uiolee commented May 17, 2024

It is recommended to release v7.3.0

@stevenjoezhang
Copy link
Member Author

I will try to fix the issue with include_code later, and then we can release a new version.

@stevenjoezhang stevenjoezhang merged commit 5ccd66e into master May 21, 2024
22 of 24 checks passed
@stevenjoezhang stevenjoezhang deleted the windows branch May 21, 2024 03:32
dimaslanjaka pushed a commit to dimaslanjaka/hexo that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants