-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(deploy): add an overview page #1211
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoshinorin The exact path of GitHub Pages guide should be |
Yes :) I think this behavior will solve if we implement this feature. I will try to it this weekend if I have a time. |
I agree with @yoshinorin that deployment -> deployment is a bit repetitive, but I don't have any good idea so far. Other than it, everything is great. Thanks for gathering those deployment methods together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SukkaW
Would you please copy it to other languages?
I can't review the Chinese doc. So, after add Chinese docs we have to ask to review to @NoahDragon, @curbengh again.
I found out the
<h2>
&<h3>
tags only have small difference.
I think we can improve the official site design more :)
Please do not merge this PR. I might bring up some style changes. After everyone happy with the coming style changes then would I copy it to all the languages. |
8b40bbd
to
d5454d4
Compare
It's able to merge after checking #1539 |
To make the document clearer, the difference between Deployer Plugins and Platforms is as follows: Deployer Plugins are plugins that allow users to compile locally and publish a blog using the 'hexo d' command. On the other hand, Platforms are more similar to providing CI/CD services. |
Theme name validation passed. |
We also need to create this page in other languages, or it will result in a 404 error. |
Or we could change the i18n plugin to redirect to home is the page in the other language does not exists? |
If wanna do that, I think we could redirect to the corresponding English page likes |
Check List
Please read and check followings before submitting a PR.
name
is unique.link
URL is correct.preview
URL is correct.preview
URL web site is rendered correctly.source/themes/screenshots
.name
.800 * 500
.png
.name
is unique.link
URL is correct.The original idea came from here. This PR adds a deployment overview page. Demo can be found at Netlify and pages will only be copied to other lang's directories after everyone is happy with the PR.