Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme: add hexo-theme-cosy #2089

Merged
merged 5 commits into from
Oct 25, 2023
Merged

theme: add hexo-theme-cosy #2089

merged 5 commits into from
Oct 25, 2023

Conversation

17px
Copy link
Contributor

@17px 17px commented Oct 23, 2023

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • name is unique.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish my plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)
    • Languages:
    • en English
    • ru Russian
    • zh-cn simplified Chinese
    • zh-tw traditional Chinese

Note

No need to translate ko, pt-br, th languages if you submit a PR for documentation.

Warning

ko, pt-br, th languages document are inactive. Please, submit issue if you want to continuous contribution to them.

@github-actions github-actions bot added the infra infrastructure, configuration of this repo label Oct 23, 2023
@github-actions
Copy link
Contributor

Theme name validation passed.
Theme thumbnails validation completed.

uiolee
uiolee requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@uiolee uiolee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @17px ,

You are committing <your theme>.yml to a wrong path.
Please follow the theme publishing doc to publish your theme.

@uiolee uiolee marked this pull request as draft October 24, 2023 17:36
@17px
Copy link
Contributor Author

17px commented Oct 25, 2023

hi @17px ,

You are committing <your theme>.yml to a wrong path. Please follow the theme publishing doc to publish your theme.

Thank you for pointing out my mistake

@github-actions github-actions bot added Themes _data/themes/ and removed infra infrastructure, configuration of this repo labels Oct 25, 2023
@17px 17px marked this pull request as ready for review October 25, 2023 01:18
@uiolee uiolee merged commit f474c13 into hexojs:master Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uiolee uiolee uiolee approved these changes

Assignees
No one assigned
Labels
Themes _data/themes/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@17px @uiolee