Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cell corruption when deleting block contents #101

Closed
wants to merge 0 commits into from
Closed

fix: cell corruption when deleting block contents #101

wants to merge 0 commits into from

Conversation

Maran1947
Copy link
Contributor

Resolves #43

Solution Approach

  • Implemented keymap handling for Ctrl+Shift+K to prevent the undesired behavior during block deletion.

@heyman
Copy link
Owner

heyman commented Jan 4, 2024

See #43 (comment)

This PR breaks the default deleteLine behavior. I think the proper solution is to implement a custom deleteLine that is block-aware (running deleteLine on a single-line block, should probably just remove the whole block).

@Maran1947 Maran1947 mentioned this pull request Jan 5, 2024
Closed
@Maran1947
Copy link
Contributor Author

See #43 (comment)

This PR breaks the default deleteLine behavior. I think the proper solution is to implement a custom deleteLine that is block-aware (running deleteLine on a single-line block, should probably just remove the whole block).

Should this work with or without the selection of a line within the block?

@Maran1947 Maran1947 closed this Jan 5, 2024
@Maran1947 Maran1947 force-pushed the bugfix/cell-corruption-when-deleting-block-contents branch from 97506fd to 37265d7 Compare January 5, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cell corruption when deleting block contents
2 participants
@Maran1947 @heyman