Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elixir support #284

Closed
wants to merge 2 commits into from
Closed

Add Elixir support #284

wants to merge 2 commits into from

Conversation

jc00ke
Copy link
Contributor

@jc00ke jc00ke commented Dec 28, 2024

Associated with #10

@YasienDwieb
Copy link
Contributor

@jc00ke I hope it's working fine with you, but I doubt you might be facing issues with selecting the languages after adding it

Reason is, I have went through this before also I don't see changes to src/editor/lang-heynote/parser.js in the changed files

For fixing this, you would need to run npm run build_grammar, and commit the changed src/editor/lang-heynote/parser.js file alongside your PR

@jc00ke
Copy link
Contributor Author

jc00ke commented Jan 3, 2025

For fixing this, you would need to run npm run build_grammar

That's what I was missing, thank you!

@jc00ke jc00ke marked this pull request as ready for review January 3, 2025 19:46
@jc00ke
Copy link
Contributor Author

jc00ke commented Jan 3, 2025

I apologize for the noiser than intended commit; my formatter did more work than we probably wanted here. I can revert the formatting if you prefer. Let me know!

@YasienDwieb
Copy link
Contributor

I think that would mostly necessary so net changes are only there, also for better git changes tracking

@heyman
Copy link
Owner

heyman commented Jan 3, 2025

Thanks for the contribution.

I apologize for the noiser than intended commit; my formatter did more work than we probably wanted here. I can revert the formatting if you prefer. Let me know!

Yes, please remove the formatting changes to keep the PR clean.

@jc00ke
Copy link
Contributor Author

jc00ke commented Jan 4, 2025

Rebased and cleaner in #288.

Thanks all for your help!

@jc00ke jc00ke closed this Jan 4, 2025
@jc00ke jc00ke deleted the elixir branch January 4, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants