Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with large buffers where block delimiters wouldn't be "atomic" when first starting Heynote, before the first edit #81

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

heyman
Copy link
Owner

@heyman heyman commented Dec 27, 2023

Increase timeout for parsing the syntax tree when it's done for the first time.

Fixes an issue with large buffers where block delimiters wouldn't be "atomic" (and thus could be corrupted) when first starting the program, before the first edit.

…getBlocks() instead of parsing the syntax tree again.

Make the block extension's getBlocks() method private.
@heyman heyman marked this pull request as ready for review December 27, 2023 11:53
@heyman heyman changed the title Increase timeout for parsing the syntax tree when it's done for the first time Fix issue with large buffers where block delimiters wouldn't be "atomic" when first starting Heynote, before the first edit Dec 27, 2023
@heyman heyman merged commit eda4981 into main Dec 27, 2023
3 checks passed
@heyman heyman deleted the syntax-tree-parse-timeout branch December 27, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant