Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Show in Dock Toggle and System Tray Feature #90

Merged
merged 13 commits into from
Jan 1, 2024

Conversation

tanuj-22
Copy link
Contributor

Resolves #62

  • Added Show in Dock Toggle in settings
  • There's a limitation in macOS with Electron, so I fixed this by adding the system tray in the menubar so that menu options are accessible in macOS.
  • Added toggle for system tray.
  • Added condition to restrict toggle of system tray when icon is hidden in the dock (ideal case)

@heyman
Copy link
Owner

heyman commented Dec 29, 2023

Nice! Have you tested this on Windows/Linux? I suspect that app.dock might be undefined on Windows and Linux (https://www.electronjs.org/docs/latest/api/app/#appdock-macos-readonly).

@tanuj-22
Copy link
Contributor Author

Nice! Have you tested this on Windows/Linux? I suspect that app.dock might be undefined on Windows and Linux (https://www.electronjs.org/docs/latest/api/app/#appdock-macos-readonly).

I have made the changes to the handle case for other platforms and have tested it on Mac and Windows. As of now, the toggle is visible only on Mac. The system tray would be visible on all platforms.

Thanks!

@heyman heyman merged commit 0ba5820 into heyman:main Jan 1, 2024
1 check passed
@heyman
Copy link
Owner

heyman commented Jan 1, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to hide macOS dock icon
2 participants