Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding traceId and a more standardized format #127

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

adding traceId and a more standardized format #127

wants to merge 6 commits into from

Conversation

CyberDracula
Copy link

  • I've added the possibility to add a traceId to the log (globally or separate on request/response/error)
  • Also change a little bit the format to make it more standardized:
    [TEST][Request][05-04-2023 01:13:38.355][1324567890987654321] GET https://github.com/hg-pyun {\"id\":1,\"text\":\"this is dummy log\"}
  • aligned the tests

@hg-pyun
Copy link
Owner

hg-pyun commented Apr 25, 2023

I'm terribly sorry for the late review! I will check and reflect it within next week.

@hg-pyun hg-pyun added the enhancement New feature or request label Apr 25, 2023
hg-pyun
hg-pyun reviewed May 16, 2023
View reviewed changes
Copy link
Owner

@hg-pyun hg-pyun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write about traceId on README.md file.

@CyberDracula
Copy link
Author

Please write about traceId on README.md file.

done ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyberDracula @hg-pyun