ci: Configure ruff
#1893
Open
ci: Configure ruff
#1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basnijholt
reviewed
Jan 31, 2024
| @@ -87,6 +87,56 @@ known-first-party= ["pint"] | |||
|
|
|||
|
|
|||
| [tool.ruff] | |||
| extend-select = [ | |||
| # "F", # pyflakes | |||
There was a problem hiding this comment.
I like how you included all options here, such that one can slowly work towards following all these rules 😄
|
@hgrecco note that you should still enable the ruff checksexplicitly, e.g. |
|
Thanks a lot! isort is enabled now! |
|
Well, isort was only an example, could you look over https://docs.astral.sh/ruff/rules/? Pyflake, pathlib, there are various rules that should be enabled, and most of them are straightforward to apply |
|
I did read it, but I am not going to enable all in bulk. I am leaning to add B, E, W and UP (in addition to the already present "E4", "E7", "E9", "F" and I) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruffpre-commit #1892pre-commit run --all-fileswith no errorsSee https://github.com/LecrisUT/pint/actions/runs/7144167989/job/19457214051?pr=1 for the failing tests