Default HHAST lints

hhvm · Feb 14, 2019 · 73e84ad · 73e84ad
1 parent bbdd364
commit 73e84ad
Show file tree

Hide file tree

Showing 6 changed files with 60 additions and 5 deletions.
diff --git a/.travis.sh b/.travis.sh
@@ -14,3 +14,6 @@ composer install
 hh_client
 
 vendor/bin/hacktest tests/
+if !(hhvm --version | grep -q -- -dev); then
+  hhvm vendor/bin/hhast-lint
+fi
diff --git a/composer.json b/composer.json
@@ -9,6 +9,7 @@
     "facebook/difflib": "^1.0.0"
   },
   "require-dev": {
-    "hhvm/hhvm-autoload": "^2.0"
+    "hhvm/hhvm-autoload": "^2.0",
+    "hhvm/hhast": "^4.0"
   }
 }
diff --git a/composer.lock b/composer.lock
diff --git a/hhast-lint.json b/hhast-lint.json
@@ -0,0 +1,3 @@
+{
+  "roots": [ "src/", "tests/" ]
+}
diff --git a/src/Assert.php b/src/Assert.php
@@ -60,6 +60,7 @@ public function assertNotSame(
   }
 
   public function assertEquals($expected, $actual, string $message = ''): void {
+    /* HHAST_IGNORE_ERROR[NoPHPEquality] */
     if ($actual == $expected) {
       return;
     }
@@ -98,6 +99,7 @@ public function assertNotEquals(
     $actual,
     string $message = '',
   ): void {
+    /* HHAST_IGNORE_ERROR[NoPHPEquality] */
     if ($actual != $expected) {
       return;
     }
@@ -164,7 +166,7 @@ public function assertNotNull($actual, string $message = '') {
   }
 
   public function assertEmpty($actual, string $message = '') {
-    if (empty($actual) == true) {
+    if (empty($actual)) {
       return;
     }
     throw new ExpectationFailedException(
@@ -177,7 +179,7 @@ public function assertEmpty($actual, string $message = '') {
   }
 
   public function assertNotEmpty($actual, string $message = '') {
-    if (empty($actual) != true) {
+    if (empty($actual)) {
       return;
     }
     throw new ExpectationFailedException(

diff --git a/src/Constraint/TraversableContains.php b/src/Constraint/TraversableContains.php
@@ -19,6 +19,7 @@ public function matches($other): bool {
       return false;
     }
     foreach ($other as $element) {
+      /* HHAST_IGNORE_ERROR[NoPHPEquality] */
       if ($element == $this->value) {
         return true;
       }