Add support for CR and CRLF line endings

fixes #5
hhvm · Jun 12, 2018 · c5f64b5 · c5f64b5
1 parent 4c20c9f
commit c5f64b5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/unparsed-blocks/parse.php b/src/unparsed-blocks/parse.php
@@ -17,6 +17,8 @@ function parse(
   string $markdown,
 ): Document {
   $lines = $markdown
+    |> Str\replace($$, "\r\n", "\n")
+    |> Str\replace($$, "\r", "\n")
     |> Str\split($$, "\n")
     |> (C\lastx($$) === '' ? Vec\slice($$, 0, C\count($$) - 1) : $$)
     |> Vec\map($$, $line ==> tuple(0, $line))

diff --git a/tests/EdgeCaseTest.php b/tests/EdgeCaseTest.php
@@ -34,6 +34,21 @@ public function getManualExamples(
         '*foo __bar *baz bim__ bam*',
         "<p><em>foo <strong>bar *baz bim</strong> bam</em></p>\n",
       ),
+      // CR
+      tuple(
+        "CR Foo\x0d\x0d> Bar\x0d\x0dBaz",
+        "<p>CR Foo</p>\n<blockquote>\n<p>Bar</p>\n</blockquote>\n<p>Baz</p>\n",
+      ),
+      // LF
+      tuple(
+        "LF Foo\x0a\x0a> Bar\x0a\x0aBaz",
+        "<p>LF Foo</p>\n<blockquote>\n<p>Bar</p>\n</blockquote>\n<p>Baz</p>\n",
+      ),
+      // CRLF
+      tuple(
+        "CRLF Foo\x0d\x0a\x0d\x0a> Bar\x0d\x0a\x0d\x0aBaz",
+        "<p>CRLF Foo</p>\n<blockquote>\n<p>Bar</p>\n</blockquote>\n<p>Baz</p>\n",
+      ),
     ];
   }