This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
add MethodNotAllowedException::getAllowedMethods() #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR also fixes the build by updating dependencies ( |
fredemmott
suggested changes
Jul 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay - inlien comments and this also needs a rebase, but generally seems good.
jjergus
reviewed
Nov 4, 2019
azjezz
commented
Nov 19, 2019
fredemmott
reviewed
Nov 19, 2019
azjezz
force-pushed
the
master
branch
2 times, most recently
from
November 19, 2019 21:56
00ee05c
to
5fc0109
Compare
fredemmott
reviewed
Nov 19, 2019
fredemmott
reviewed
Nov 19, 2019
fredemmott
reviewed
Nov 19, 2019
azjezz
force-pushed
the
master
branch
2 times, most recently
from
November 19, 2019 22:22
790fa0b
to
28b7bb3
Compare
jjergus
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me!
Just one comment in the code + can you please address the lint warning?
Will merge once lint's fixed
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds the
getAllowedMethods()
method to theMethodNotAllowedException
exception class.this helps developers to send the correct
Allow
header value.see : https://tools.ietf.org/html/rfc7231#section-7.4.1
see : https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Allow
see : https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405
Example :