-
Notifications
You must be signed in to change notification settings - Fork 14
Changed Hack Collections with Hack Arrays #22
base: main
Are you sure you want to change the base?
Conversation
I had to add the hsl-experimental prior version, since some project packages still need that version to work (due to the \Experimental\ being removed) |
This allows the newer hsl-experimental. refs #22
The HHAST errors need a new release of HHAST with the new schema; you also need to adjust .travis.yml for the new minimum version |
@@ -16,7 +16,7 @@ | |||
}, | |||
"require-dev": { | |||
"facebook/fbexpect": "^2.0", | |||
"hhvm/hhast": "^4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just meant that the new release had to actually be released; this should be automatically picked up based on hhast's own version requirements, now that it's happened.
Sorry for waking this PR from its slumber. This PR has merge conflicts. Would you mind if I took your changes and redid this If you've moved on or are unable to reply for any reason, I'll use a with great thanks to CarusoX instead. |
Sound fine to me @lexidor! Thanks for the mention! |
Replaced:
Vector, ImmVector
withvec
Map, ImmMap
withdict
.Updated the needed documentation on the README.