Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Changed Hack Collections with Hack Arrays #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CarusoX
Copy link

@CarusoX CarusoX commented Apr 2, 2020

Replaced:

  • Vector, ImmVector with vec
  • Map, ImmMap with dict.

Updated the needed documentation on the README.

@CarusoX
Copy link
Author

CarusoX commented Apr 3, 2020

I had to add the hsl-experimental prior version, since some project packages still need that version to work (due to the \Experimental\ being removed)

@CarusoX CarusoX marked this pull request as ready for review April 3, 2020 05:37
fredemmott added a commit that referenced this pull request Apr 8, 2020
This allows the newer hsl-experimental.

refs #22
@fredemmott
Copy link
Contributor

The HHAST errors need a new release of HHAST with the new schema; you also need to adjust .travis.yml for the new minimum version

@@ -16,7 +16,7 @@
},
"require-dev": {
"facebook/fbexpect": "^2.0",
"hhvm/hhast": "^4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just meant that the new release had to actually be released; this should be automatically picked up based on hhast's own version requirements, now that it's happened.

@lexidor
Copy link
Contributor

lexidor commented May 25, 2023

Sorry for waking this PR from its slumber. This PR has merge conflicts.

Would you mind if I took your changes and redid this collection -> array migration? How would you like to be credited / get attribution for your work? Would you like a Co-authored by mention? This might imply you agree with my changes though, so that's why I felt I had to ask before doing so.

If you've moved on or are unable to reply for any reason, I'll use a with great thanks to CarusoX instead.

@CarusoX
Copy link
Author

CarusoX commented May 29, 2023

Sound fine to me @lexidor! Thanks for the mention!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants