Skip to content

Commit

Permalink
update rx FIXME number (#157)
Browse files Browse the repository at this point in the history
Summary:
Looks like the change from `<<__Rx>>` to `[rx]` requires a different FIXME number.

Pull Request resolved: #157

Test Plan: https://github.com/hhvm/hsl/pull/157/checks

Reviewed By: DavidSnider

Differential Revision: D26379817

Pulled By: jjergus

fbshipit-source-id: eb890f5f565dfbf625bd68f4b383e75a4ff7aaa5
  • Loading branch information
jjergus authored and facebook-github-bot committed Feb 11, 2021
1 parent e594954 commit 6378dbe
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/str/transform.php
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ function replace_ci(
string $needle,
string $replacement,
)[rx]: string {
/* HH_FIXME[4200] Rx calling non-rx */
/* HH_FIXME[4390] Rx calling non-rx */
/* HH_FIXME[2049] calling stdlib directly */
/* HH_FIXME[4107] calling stdlib directly */
return \str_ireplace($needle, $replacement, $haystack);
Expand Down Expand Up @@ -245,7 +245,7 @@ function replace_every_ci(
)[rx]: string {
/* HH_FIXME[2049] calling stdlib directly */
/* HH_FIXME[4107] calling stdlib directly */
/* HH_FIXME[4200] Rx calling non-rx */
/* HH_FIXME[4390] Rx calling non-rx */
return \str_ireplace(
/* HH_FIXME[2049] calling stdlib directly */
/* HH_FIXME[4107] calling stdlib directly */
Expand Down

0 comments on commit 6378dbe

Please sign in to comment.