Skip to content

Commit

Permalink
require HHVM 4.94 (#162)
Browse files Browse the repository at this point in the history
Summary:
HSL now references the `write_props` context which was not added until HHVM 4.94 (facebook/hhvm@5228a9a)

Pull Request resolved: #162

Reviewed By: DavidSnider

Differential Revision: D26736246

Pulled By: jjergus

fbshipit-source-id: 603cde3a5d6f61b00fd429119f5fd22ffdc625d3
  • Loading branch information
jjergus authored and facebook-github-bot committed Mar 1, 2021
1 parent 2211f05 commit 9b660aa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
matrix:
os: [ ubuntu ]
hhvm:
- '4.93'
- '4.94'
- latest
- nightly
runs-on: ${{matrix.os}}-latest
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
"hhvm/hsl-experimental": "^4.37|dev-master"
},
"require": {
"hhvm": "^4.93"
"hhvm": "^4.94"
}
}

0 comments on commit 9b660aa

Please sign in to comment.