Fix Node::__construct $children type

Hack now typechecks XHP constructors (facebook/hhvm@af6f350) which revealed this error.
hhvm · Feb 18, 2021 · 7d2d31e · 7d2d31e
1 parent 074b88b
commit 7d2d31e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/core/Node.hack b/src/core/Node.hack
@@ -49,7 +49,7 @@ abstract xhp class node implements \XHPChild {
    */
   final public function __construct(
     KeyedTraversable<string, mixed> $attributes,
-    Traversable<\XHPChild> $children,
+    Traversable<?\XHPChild> $children,
     dynamic ...$debug_info
   ) {
     invariant(

diff --git a/tests/BasicsTest.hack b/tests/BasicsTest.hack
@@ -246,6 +246,11 @@ class BasicsTest extends Facebook\HackTest\HackTest {
     expect(await $xhp->toStringAsync())->toEqual('<div>herpderp</div>');
   }
 
+  public async function testScalarChildren(): Awaitable<void> {
+    $xhp = <div>{42}{' str '}{3.14}{null}</div>;
+    expect(await $xhp->toStringAsync())->toEqual('<div>42 str 3.14</div>');
+  }
+
   public async function testEscaping(): Awaitable<void> {
     $xhp = <div>{'foo<SCRIPT>bar'}</div>;
     expect(await $xhp->toStringAsync())->toEqual(