Move leaflet dependency to dev-dependencies #23

olzraiti · 2016-11-07T10:19:38Z

This pull request makes this library to use the host packages leaflet dependency. It's explained quite well here why plugins should use peer dependencies for the libraries they are targetting for: https://nodejs.org/en/blog/npm/peer-dependencies/

zakjan · 2016-11-07T12:51:54Z

Following this PR, autoprefixer and postcss-loader should be in devDependencies too.

olzraiti · 2016-11-07T12:59:15Z

Agree! I can add the changes to this PR, just a minute.

houndci-bot · 2016-11-07T13:06:51Z

lib/Icon.js

@@ -43,7 +43,7 @@ var Icon = function (_Leaflet$Icon) {
  function Icon(options) {
    _classCallCheck(this, Icon);

-    var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(Icon).call(this, options));
+    var _this = _possibleConstructorReturn(this, (Icon.__proto__ || Object.getPrototypeOf(Icon)).call(this, options));


Line is too long.
The 'proto' property is deprecated.

houndci-bot · 2016-11-07T13:06:51Z

dist/leaflet-vector-markers.js

@@ -162,7 +162,7 @@ return /******/ (function(modules) { // webpackBootstrap
 	  function Icon(options) {
 	    _classCallCheck(this, Icon);

-	    var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(Icon).call(this, options));
+	    var _this = _possibleConstructorReturn(this, (Icon.__proto__ || Object.getPrototypeOf(Icon)).call(this, options));


Line is too long.

olzraiti · 2016-11-07T13:09:57Z

Done.

Another option would be to add a postinstall script, that would run the build scripts - it feels a bit awkward to keep the lib and dist folders in the git repo (contributors must always manually remember to build them before pushing), whereas they could be always built from source upon installing.

Although I'd prefer to see this library in NPM someday, so we could use the npm publish hooks and not worry about the build directories in the git tree or bloating the install script. Just a suggestion :)

zakjan · 2016-11-07T13:13:12Z

👍
It already is in npm, https://www.npmjs.com/package/Leaflet.vector-markers, and it looks like @hiasinho is publishing there every release.

olzraiti · 2016-11-07T13:18:39Z

Oh, thanks! I didn't realize that because the NPM repo autosuggest feature doesn't suggest this library if you type "leaflet vector" or even "Leaflet.vector"...

~~I'll add an npm publish hook.~~

EDIT: I decided not to add the npm publish hook because I consider npm prepublish broken because running npm install runs npm prepublish for some reason and this can cause problems. I personally use a custom npm script publish-to-npm which does the following:

npm version patch && git push && npm run build && npm publish

The maintainers probably have an opininion how they want to handle publishing, and so I won't try to force my publishing style here.

chrisflatley · 2016-12-08T09:09:40Z

Could we change the dependency (peer certainly, but potentially dev as well) to be:

"leaflet": "> 0.7.0"

The changes suggests in #26 #25 (pull request already made there - thanks @zakjan) allow this to work with Leaflet 1.0+. which will be the target for most new leaflet apps.

houndci-bot · 2016-12-08T09:44:43Z

lib/Icon.js

@@ -43,7 +43,7 @@ var Icon = function (_Leaflet$Icon) {
  function Icon(options) {
    _classCallCheck(this, Icon);

-    var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(Icon).call(this, options));
+    var _this = _possibleConstructorReturn(this, (Icon.__proto__ || Object.getPrototypeOf(Icon)).call(this, options));


Line is too long.
The 'proto' property is deprecated.

houndci-bot · 2016-12-08T09:44:43Z

dist/leaflet-vector-markers.js

@@ -162,7 +162,7 @@ return /******/ (function(modules) { // webpackBootstrap
 	  function Icon(options) {
 	    _classCallCheck(this, Icon);

-	    var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(Icon).call(this, options));
+	    var _this = _possibleConstructorReturn(this, (Icon.__proto__ || Object.getPrototypeOf(Icon)).call(this, options));


Line is too long.

zakjan · 2017-03-27T14:34:10Z

@hiasinho Hi, could we merge this PR? This library is now fully compatible with Leaflet 1.0.3. I have to keep my fork just because of strict required version of Leaflet dependency.

houndci-bot · 2023-11-02T10:39:12Z

dist/leaflet-vector-markers.js

+
+function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" || typeof call === "function") ? call : self; }
+
+function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function, not " + typeof superClass); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, enumerable: false, writable: true, configurable: true } }); if (superClass) Object.setPrototypeOf ? Object.setPrototypeOf(subClass, superClass) : subClass.__proto__ = superClass; }


Line is too long.
Too many errors. (36% scanned).

houndci-bot · 2023-11-02T10:39:12Z

dist/leaflet-vector-markers.js

+
+function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
+
+function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" || typeof call === "function") ? call : self; }


Line is too long.
Mixed double and single quotes.

houndci-bot · 2023-11-02T10:39:12Z

dist/leaflet-vector-markers.js

+
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+
+function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }


Line is too long.
Mixed double and single quotes.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+
+var _leaflet2 = _interopRequireDefault(_leaflet);
+
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }


Line is too long.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

-	var _Icon2 = __webpack_require__(3);
+var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();
+
+var _leaflet = __webpack_require__(0);


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+/******/ 	};
+/******/
+/******/ 	// Object.prototype.hasOwnProperty.call
+/******/ 	__webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };


Identifier 'webpack_require' is not in camel case.
Line is too long.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+/******/ 		var getter = module && module.__esModule ?
+/******/ 			function getDefault() { return module['default']; } :
+/******/ 			function getModuleExports() { return module; };
+/******/ 		__webpack_require__.d(getter, 'a', getter);


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+/******/ 	};
+/******/
+/******/ 	// getDefaultExport function for compatibility with non-harmony modules
+/******/ 	__webpack_require__.n = function(module) {


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+/******/ 		}
+/******/ 	};
+/******/
+/******/ 	// getDefaultExport function for compatibility with non-harmony modules


Line is too long.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/
+/******/ 	// define getter function for harmony exports
+/******/ 	__webpack_require__.d = function(exports, name, getter) {
+/******/ 		if(!__webpack_require__.o(exports, name)) {


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+
+function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" || typeof call === "function") ? call : self; }
+
+function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function, not " + typeof superClass); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, enumerable: false, writable: true, configurable: true } }); if (superClass) Object.setPrototypeOf ? Object.setPrototypeOf(subClass, superClass) : subClass.__proto__ = superClass; }


Line is too long.
Too many errors. (36% scanned).

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+
+function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
+
+function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" || typeof call === "function") ? call : self; }


Line is too long.
Mixed double and single quotes.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+
+function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }


Line is too long.
Mixed double and single quotes.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+
+var _leaflet2 = _interopRequireDefault(_leaflet);
+
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }


Line is too long.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

-	var _Icon2 = __webpack_require__(3);
+var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();
+
+var _leaflet = __webpack_require__(0);


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 	};
+/******/
+/******/ 	// Object.prototype.hasOwnProperty.call
+/******/ 	__webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };


Identifier 'webpack_require' is not in camel case.
Line is too long.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 		var getter = module && module.__esModule ?
+/******/ 			function getDefault() { return module['default']; } :
+/******/ 			function getModuleExports() { return module; };
+/******/ 		__webpack_require__.d(getter, 'a', getter);


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 	};
+/******/
+/******/ 	// getDefaultExport function for compatibility with non-harmony modules
+/******/ 	__webpack_require__.n = function(module) {


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 		}
+/******/ 	};
+/******/
+/******/ 	// getDefaultExport function for compatibility with non-harmony modules


Line is too long.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/
+/******/ 	// define getter function for harmony exports
+/******/ 	__webpack_require__.d = function(exports, name, getter) {
+/******/ 		if(!__webpack_require__.o(exports, name)) {


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+
+function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" || typeof call === "function") ? call : self; }
+
+function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function, not " + typeof superClass); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, enumerable: false, writable: true, configurable: true } }); if (superClass) Object.setPrototypeOf ? Object.setPrototypeOf(subClass, superClass) : subClass.__proto__ = superClass; }


Line is too long.
Too many errors. (36% scanned).

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+
+function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
+
+function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" || typeof call === "function") ? call : self; }


Line is too long.
Mixed double and single quotes.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+
+function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }


Line is too long.
Mixed double and single quotes.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+
+var _leaflet2 = _interopRequireDefault(_leaflet);
+
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }


Line is too long.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

-	var _Icon2 = __webpack_require__(3);
+var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();
+
+var _leaflet = __webpack_require__(0);


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 	};
+/******/
+/******/ 	// Object.prototype.hasOwnProperty.call
+/******/ 	__webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };


Identifier 'webpack_require' is not in camel case.
Line is too long.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 		var getter = module && module.__esModule ?
+/******/ 			function getDefault() { return module['default']; } :
+/******/ 			function getModuleExports() { return module; };
+/******/ 		__webpack_require__.d(getter, 'a', getter);


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 	};
+/******/
+/******/ 	// getDefaultExport function for compatibility with non-harmony modules
+/******/ 	__webpack_require__.n = function(module) {


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 		}
+/******/ 	};
+/******/
+/******/ 	// getDefaultExport function for compatibility with non-harmony modules


Line is too long.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/
+/******/ 	// define getter function for harmony exports
+/******/ 	__webpack_require__.d = function(exports, name, getter) {
+/******/ 		if(!__webpack_require__.o(exports, name)) {


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:13Z

dist/leaflet-vector-markers.js

+
+function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" || typeof call === "function") ? call : self; }
+
+function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function, not " + typeof superClass); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, enumerable: false, writable: true, configurable: true } }); if (superClass) Object.setPrototypeOf ? Object.setPrototypeOf(subClass, superClass) : subClass.__proto__ = superClass; }


Line is too long.
Too many errors. (36% scanned).

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+
+function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
+
+function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" || typeof call === "function") ? call : self; }


Line is too long.
Mixed double and single quotes.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+
+function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }


Line is too long.
Mixed double and single quotes.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+
+var _leaflet2 = _interopRequireDefault(_leaflet);
+
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }


Line is too long.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

-	var _Icon2 = __webpack_require__(3);
+var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();
+
+var _leaflet = __webpack_require__(0);


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 	};
+/******/
+/******/ 	// Object.prototype.hasOwnProperty.call
+/******/ 	__webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };


Identifier 'webpack_require' is not in camel case.
Line is too long.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 		var getter = module && module.__esModule ?
+/******/ 			function getDefault() { return module['default']; } :
+/******/ 			function getModuleExports() { return module; };
+/******/ 		__webpack_require__.d(getter, 'a', getter);


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 	};
+/******/
+/******/ 	// getDefaultExport function for compatibility with non-harmony modules
+/******/ 	__webpack_require__.n = function(module) {


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:39:14Z

dist/leaflet-vector-markers.js

+/******/ 		}
+/******/ 	};
+/******/
+/******/ 	// getDefaultExport function for compatibility with non-harmony modules


Line is too long.

houndci-bot · 2023-11-02T10:39:15Z

dist/leaflet-vector-markers.js

+/******/
+/******/ 	// define getter function for harmony exports
+/******/ 	__webpack_require__.d = function(exports, name, getter) {
+/******/ 		if(!__webpack_require__.o(exports, name)) {


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:43:37Z

dist/leaflet-vector-markers.js

-
+/******/
+/******/ 	// define getter function for harmony exports
+/******/ 	__webpack_require__.d = function(exports, name, getter) {


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:43:38Z

dist/leaflet-vector-markers.js

-
+/******/
+/******/ 	// define getter function for harmony exports
+/******/ 	__webpack_require__.d = function(exports, name, getter) {


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:43:38Z

dist/leaflet-vector-markers.js

-
+/******/
+/******/ 	// define getter function for harmony exports
+/******/ 	__webpack_require__.d = function(exports, name, getter) {


Identifier 'webpack_require' is not in camel case.

houndci-bot · 2023-11-02T10:43:38Z

webpack.config.js

      }
    ]
  },
  plugins: [
-    new ExtractTextPlugin("leaflet-vector-markers.css")
+    new ExtractTextPlugin({filename: "leaflet-vector-markers.css"})


Mixed double and single quotes.

houndci-bot · 2023-11-02T10:43:39Z

webpack.config.js

+						{
+							loader: 'sass-loader',
+							options: {
+								includePaths: [path.resolve(__dirname, "./src")]


'__dirname' is not defined.
Mixed double and single quotes.

houndci-bot · 2023-11-02T10:43:39Z

webpack.config.js

+						{
+							loader: 'postcss-loader',
+							options: {
+								plugins: () => [ autoprefixer({ browsers: ['last 3 version', '> 10%', 'IE 8'] }) ]


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
Line is too long.

Move leaflet dependency to dev-dependencies

79f9267

Move all remaining dependencies to dev-dependencies

8e33bbf

houndci-bot reviewed Nov 7, 2016

View reviewed changes

Update leaflet dependency to be 0.7.0 or higher

ffec761

houndci-bot reviewed Dec 8, 2016

View reviewed changes

update deps so that works with node 16 (node-sass build failed)

f1b9ddb

houndci-bot reviewed Nov 2, 2023

View reviewed changes

use rimraf so works with windows

90cee10

houndci-bot reviewed Nov 2, 2023

View reviewed changes


		function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" \|\| typeof call === "function") ? call : self; }

		function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function, not " + typeof superClass); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, enumerable: false, writable: true, configurable: true } }); if (superClass) Object.setPrototypeOf ? Object.setPrototypeOf(subClass, superClass) : subClass.__proto__ = superClass; }


		function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }

		function _possibleConstructorReturn(self, call) { if (!self) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return call && (typeof call === "object" \|\| typeof call === "function") ? call : self; }


		function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

		function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }


		var _leaflet2 = _interopRequireDefault(_leaflet);

		function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

Move leaflet dependency to dev-dependencies #23

Are you sure you want to change the base?

Move leaflet dependency to dev-dependencies #23

Conversation

olzraiti commented Nov 7, 2016

zakjan commented Nov 7, 2016 • edited Loading

olzraiti commented Nov 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olzraiti commented Nov 7, 2016

zakjan commented Nov 7, 2016 • edited Loading

olzraiti commented Nov 7, 2016 • edited Loading

chrisflatley commented Dec 8, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zakjan commented Mar 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zakjan commented Nov 7, 2016 •

edited

Loading

zakjan commented Nov 7, 2016 •

edited

Loading

olzraiti commented Nov 7, 2016 •

edited

Loading