Add opacity option #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 8, 2016
| @@ -31,7 +32,7 @@ export default class Icon extends Leaflet.Icon { | |||
| const options = this.options | |||
| const pin_path = options.map_pin || mapPin | |||
|
|
|||
| div.innerHTML = `<svg width="${options.iconSize[0]}px" height="${options.iconSize[1]}px" viewBox="${options.viewBox}" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><path d="${pin_path}" fill="${options.markerColor}"></path></svg>` | |||
| div.innerHTML = `<svg width="${options.iconSize[0]}px" height="${options.iconSize[1]}px" viewBox="${options.viewBox}" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><path d="${pin_path}" fill="${options.markerColor}" opacity="${options.opacity}"></path></svg>` | |||
There was a problem hiding this comment.
Line is too long.
'template literal syntax' is only available in ES6 (use 'esversion: 6').
Identifier 'pin_path' is not in camel case.
Missing semicolon.
houndci-bot
reviewed
Dec 8, 2016
| @@ -57,7 +58,7 @@ var Icon = function (_Leaflet$Icon) { | |||
| var options = this.options; | |||
| var pin_path = options.map_pin || mapPin; | |||
|
|
|||
| div.innerHTML = '<svg width="' + options.iconSize[0] + 'px" height="' + options.iconSize[1] + 'px" viewBox="' + options.viewBox + '" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><path d="' + pin_path + '" fill="' + options.markerColor + '"></path></svg>'; | |||
| div.innerHTML = '<svg width="' + options.iconSize[0] + 'px" height="' + options.iconSize[1] + 'px" viewBox="' + options.viewBox + '" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><path d="' + pin_path + '" fill="' + options.markerColor + '" opacity="' + options.opacity + '"></path></svg>'; | |||
There was a problem hiding this comment.
Line is too long.
Identifier 'pin_path' is not in camel case.
houndci-bot
reviewed
Dec 8, 2016
| @@ -43,7 +44,7 @@ var Icon = function (_Leaflet$Icon) { | |||
| function Icon(options) { | |||
| _classCallCheck(this, Icon); | |||
|
|
|||
| var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(Icon).call(this, options)); | |||
| var _this = _possibleConstructorReturn(this, (Icon.__proto__ || Object.getPrototypeOf(Icon)).call(this, options)); | |||
There was a problem hiding this comment.
Line is too long.
The 'proto' property is deprecated.
houndci-bot
reviewed
Dec 8, 2016
| @@ -176,7 +177,7 @@ return /******/ (function(modules) { // webpackBootstrap | |||
| var options = this.options; | |||
| var pin_path = options.map_pin || mapPin; | |||
|
|
|||
| div.innerHTML = '<svg width="' + options.iconSize[0] + 'px" height="' + options.iconSize[1] + 'px" viewBox="' + options.viewBox + '" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><path d="' + pin_path + '" fill="' + options.markerColor + '"></path></svg>'; | |||
| div.innerHTML = '<svg width="' + options.iconSize[0] + 'px" height="' + options.iconSize[1] + 'px" viewBox="' + options.viewBox + '" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><path d="' + pin_path + '" fill="' + options.markerColor + '" opacity="' + options.opacity + '"></path></svg>'; | |||
houndci-bot
reviewed
Dec 8, 2016
| @@ -162,7 +163,7 @@ return /******/ (function(modules) { // webpackBootstrap | |||
| function Icon(options) { | |||
| _classCallCheck(this, Icon); | |||
|
|
|||
| var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(Icon).call(this, options)); | |||
| var _this = _possibleConstructorReturn(this, (Icon.__proto__ || Object.getPrototypeOf(Icon)).call(this, options)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows giving opacity to the marker. Leaflet API allows giving opacity to markers, so it should be possible to implement opacity with this library.