Make it really work without prefix #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 31, 2017
| i.classList.add(options.prefix + '-' + options.icon) | ||
| i.classList.add(options.prefix) |
| @@ -43,7 +43,7 @@ var Icon = function (_Leaflet$Icon) { | |||
| function Icon(options) { | |||
| _classCallCheck(this, Icon); | |||
|
|
|||
| var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(Icon).call(this, options)); | |||
| var _this = _possibleConstructorReturn(this, (Icon.__proto__ || Object.getPrototypeOf(Icon)).call(this, options)); | |||
There was a problem hiding this comment.
Line is too long.
The 'proto' property is deprecated.
| /* 3 */ | ||
| /***/ function(module, exports, __webpack_require__) { | ||
| /***/ (function(module, exports, __webpack_require__) { |
There was a problem hiding this comment.
Identifier 'webpack_require' is not in camel case.
| /* 2 */ | ||
| /***/ function(module, exports, __webpack_require__) { | ||
| /***/ (function(module, exports, __webpack_require__) { |
There was a problem hiding this comment.
Identifier 'webpack_require' is not in camel case.
Wrapping non-IIFE function literals in parens is unnecessary.
| /* 1 */ | ||
| /***/ function(module, exports) { | ||
| /***/ (function(module, exports) { |
There was a problem hiding this comment.
'exports' is defined but never used.
Wrapping non-IIFE function literals in parens is unnecessary.
| @@ -52,7 +52,7 @@ return /******/ (function(modules) { // webpackBootstrap | |||
| /************************************************************************/ | |||
| /******/ ([ | |||
| /* 0 */ | |||
| /***/ function(module, exports, __webpack_require__) { | |||
| /***/ (function(module, exports, __webpack_require__) { | |||
There was a problem hiding this comment.
Identifier 'webpack_require' is not in camel case.
Wrapping non-IIFE function literals in parens is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant changes in src/Icon.js:
Check whether options.prefix is set and is a string before passing it to i.classList.add() because this function throws an error if the argument is not a string.