Fix empty check of var.{public,private}-subnets, delay health check, 2.0.0-beta.3
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
changed the title
[], check length 0var.{public,private}-subnets
manics
changed the title
var.{public,private}-subnetsvar.{public,private}-subnets, 2.0.0-beta.3
manics
force-pushed
the
fix-subnet-comparison
branch
from
b703895
to
b0a72f2
Compare
manics
changed the title
var.{public,private}-subnets, 2.0.0-beta.3var.{public,private}-subnets, delay health check, 2.0.0-beta.3
manics
force-pushed
the
fix-subnet-comparison
branch
from
b0a72f2
to
fb7c371
Compare
AaronJackson
approved these changes
Apr 24, 2024
manics
force-pushed
the
fix-subnet-comparison
branch
from
54a14cd
to
4c92a0a
Compare
The ternary operator uses short-circuiting, whereas `coalescelist` always evaluates `module.vpc[0].private_subnets` and fails if `module.vpc[0]` doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
var.public-subnets == []returns false when the default value ofpublic-subnetsis[]because it's treated astolist([]).The startup time of this container seems to cross the boundary of where ECS considers the task as unhealthy due to multiple health checks failing, so this adds a 3 minutes delay before checking the health of the task.
Also prepares another beta release, 2.0.0-beta.3.