Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc_id_mapping to IVF #151

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add doc_id_mapping to IVF #151

merged 1 commit into from
Dec 3, 2024

Conversation

tyb0807
Copy link
Collaborator

@tyb0807 tyb0807 commented Dec 2, 2024

No description provided.

Copy link
Owner

@hicder hicder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments

rs/index/src/ivf/index.rs Outdated Show resolved Hide resolved
rs/index/src/ivf/index.rs Outdated Show resolved Hide resolved
rs/index/src/ivf/builder.rs Outdated Show resolved Hide resolved
@hicder
Copy link
Owner

hicder commented Dec 2, 2024

can you also rebase to see if it still compiles?

Copy link
Owner

@hicder hicder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tyb0807 tyb0807 merged commit c356575 into master Dec 3, 2024
2 checks passed
@tyb0807 tyb0807 deleted the tyb0807/ivf branch December 3, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants