-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging fix #184
Logging fix #184
Conversation
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 90.51% 90.52%
=======================================
Files 57 57
Lines 7455 7449 -6
=======================================
- Hits 6748 6743 -5
+ Misses 707 706 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
If you are removing |
~~Earlier `monty.dev.requires` was not using `functools.wraps`. In recent versions, they might have changed it. This change obsoletes the need for `SimsoptRequires`.~~
~~Anyhow, let's not use either of them to decorate classes because
functools.wraps is not working for classes.~~
Sorry I forgot why I introduced SimsoptRequires. It was introduced to make sure instancecheck works, by redefining __instancecheck__. I am going to use `SimsoptRequires` in place of `dev.monty.requires` and see if it fixes the docs issue.
|
This PR fixes bugs encountered in importing
initialize_logging
fromsimsopt.util.logging
reported in #178.functools.wraps
works only for functions, so usingSimsoptRequires
, which usesfunctools.wraps
internally, on classes won't work as expected. Hence,SimsoptRequires
is removed in MHD modules.