feat: introduce new mechanism for key setting when creating an account #2188
+544
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naydenov <[email protected]>
Signed-off-by: Naydenov <[email protected]>
…cifications-for-AccountCreateTransaction
Signed-off-by: Naydenov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2188 +/- ##
============================================
- Coverage 82.20% 78.74% -3.46%
- Complexity 3588 4101 +513
============================================
Files 186 243 +57
Lines 11697 13764 +2067
Branches 1150 1337 +187
============================================
+ Hits 9615 10838 +1223
- Misses 1604 2454 +850
+ Partials 478 472 -6 ☔ View full report in Codecov by Sentry. |
0xivanov
reviewed
Jan 21, 2025
sdk/src/test/java/org/hiero/sdk/AccountCreateTransactionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Naydenov <[email protected]>
Signed-off-by: Naydenov <[email protected]>
…-for-AccountCreateTransaction
Signed-off-by: Naydenov <[email protected]>
Signed-off-by: Naydenov <[email protected]>
Signed-off-by: Naydenov <[email protected]>
0xivanov
reviewed
Jan 23, 2025
examples/src/main/java/org/hiero/sdk/examples/AccountCreateWithAndWithoutAliasExample.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/org/hiero/sdk/examples/AccountCreateWithAndWithoutAliasExample.java
Show resolved
Hide resolved
examples/src/main/java/org/hiero/sdk/examples/AccountCreateWithAndWithoutAliasExample.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Naydenov <[email protected]>
Signed-off-by: Naydenov <[email protected]>
Signed-off-by: Naydenov <[email protected]>
Signed-off-by: Naydenov <[email protected]>
0xivanov
reviewed
Jan 24, 2025
sdk/src/test/java/org/hiero/sdk/AccountCreateTransactionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Naydenov <[email protected]>
0xivanov
reviewed
Jan 30, 2025
Comment on lines
+356
to
+357
| @DisplayName("Cannot create account with alias different from admin key without both key signature") | ||
| void cannotCreateAccountWithAliasWithoutBothKeySignatures() throws Exception { |
There was a problem hiding this comment.
This test was reworked to test passing ed key
0xivanov
reviewed
Jan 30, 2025
| * Demonstrates different methods of creating Hedera accounts with various key configurations. | ||
| * Shows how to create accounts with and without aliases using different key types. | ||
| */ | ||
| public class AccountCreateWithAndWithoutAliasExample { |
There was a problem hiding this comment.
Maybe it's a good idea to rework the already existing example for alias. I forgot we had one.
There was a problem hiding this comment.
And to replace all instances where we call setKey to the new setKeyWithoutAlias
0xivanov
deleted the
1219-Streamline-key-and-alias-specifications-for-AccountCreateTransaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
introduce new mechanism for key setting when creating an account
Related issue(s):
Fixes #2177
Notes for reviewer:
Checklist