Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fix): resolve incompatibility with latest pnpm #2829

Conversation

venilinvasilev
Copy link
Contributor

@venilinvasilev venilinvasilev commented Jan 28, 2025

Description:
This PR fixes issue with failing task install script due to types/node version incompatibility for pnpm versions greater than or equal to 9.

Related issue(s):
#2828

Checklist

  • Bump types/node to version ^22.x.

@venilinvasilev venilinvasilev requested a review from a team as a code owner January 28, 2025 10:56
@venilinvasilev venilinvasilev force-pushed the fix/task-install-pnpm-incompatible-types-node branch 2 times, most recently from 7987bef to 7078958 Compare January 28, 2025 12:28
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@venilinvasilev venilinvasilev force-pushed the fix/task-install-pnpm-incompatible-types-node branch from 7078958 to 2f1bd1f Compare January 29, 2025 07:02
@venilinvasilev venilinvasilev changed the title fix: task install fails on latest pnpm due to incompatible types/node fix(types): resolve incompatibility with latest pnpm Jan 29, 2025
Bump types/node to version ^22.x to resolve installation failures with pnpm.

Signed-off-by: venilinvasilev <[email protected]>
@venilinvasilev venilinvasilev force-pushed the fix/task-install-pnpm-incompatible-types-node branch from ce45469 to fcfd48f Compare January 29, 2025 07:06
@venilinvasilev venilinvasilev changed the title fix(types): resolve incompatibility with latest pnpm chore(fix): resolve incompatibility with latest pnpm Jan 29, 2025
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit 006c136 into hiero-ledger:main Feb 11, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants