Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/parsing-envs #513

Merged
merged 4 commits into from
Apr 11, 2024
Merged

fix/parsing-envs #513

merged 4 commits into from
Apr 11, 2024

Conversation

PaulDalek
Copy link
Contributor

Corrected the way envs are parsed with Zod and some other minor fixes.

@PaulDalek PaulDalek requested a review from jszuminski April 9, 2024 15:02
@PaulDalek PaulDalek self-assigned this Apr 9, 2024
Copy link
Contributor

@jszuminski jszuminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

Not so sure about the HIGHCHARTS_CORE name instead of HIGHCHARTS_CORE_SCRIPTS, I'm not sure which would be more intuitive and more informative here, but I guess it's a matter of preference, so no difference to me.

@PaulDalek
Copy link
Contributor Author

@jszuminski Renamed the HIGHCHARTS_MODULES and HIGHCHARTS_INDICATORS environment variables respectively to HIGHCHARTS_MODULE_SCRIPTS and HIGHCHARTS_INDICATOR_SCRIPTS and left the HIGHCHARTS_CORE_SCRIPTS as it was before.

@PaulDalek PaulDalek merged commit 64824fe into master Apr 11, 2024
2 checks passed
@PaulDalek PaulDalek deleted the fix/parsing-envs branch April 11, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants